Revert "Add power-source selection for hybrid inverter controls"#392
Merged
tiyash-basu-frequenz merged 1 commit intofrequenz-floss:v0.x.xfrom Apr 28, 2026
Conversation
This reverts commit 3d497c8. We have eventually decided to not include the power-source selection for hybrid inverter controls in the API in this form, due to the complexities and potential for confusion it introduces. Instead, we will explore alternative approaches, strengthened by tests on the field, to provide users with the necessary control over power sources in a more intuitive and user-friendly manner. Signed-off-by: Tiyash Basu <tiyash.basu@frequenz.com>
ab767c6 to
f612ac3
Compare
There was a problem hiding this comment.
Pull request overview
Reverts the previously introduced “power-source selection” API surface for hybrid inverter discharge commands, removing the PowerSource enum and the power_source request field from the preview microgrid protobuf APIs, and updating release notes accordingly.
Changes:
- Removed
PowerSourceenum fromv1alpha18andv1alpha19microgrid protos. - Removed
SetElectricalComponentPowerRequest.power_sourcefrom both preview protos (and renumbered remaining fields inv1alpha19). - Updated
RELEASE_NOTES.mdto drop thev1alpha18additions mention and adjustv1alpha19description text.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| proto/frequenz/api/microgrid/v1alpha19/microgrid.proto | Removes PowerSource / power_source and renumbers remaining request fields. |
| proto/frequenz/api/microgrid/v1alpha18/microgrid.proto | Removes PowerSource / power_source while keeping existing field tags for remaining fields. |
| RELEASE_NOTES.md | Removes references to the reverted additions and updates upgrade guidance wording. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
llucax
approved these changes
Apr 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This reverts commit 3d497c8.
We have eventually decided to not include the power-source selection for hybrid inverter controls in the API in this form, due to the complexities and potential for confusion it introduces. Instead, we will explore alternative approaches, strengthened by tests on the field, to provide users with the necessary control over power sources in a more intuitive and user-friendly manner.
Note that this change was not yet released, so this removal does not break anything for the end-users of this API.