Add v1alpha19 API and rename ComponentTelemetryStreamFilter#347
Merged
tiyash-basu-frequenz merged 3 commits intofrequenz-floss:v0.x.xfrom Jul 17, 2025
Merged
Conversation
Signed-off-by: Tiyash Basu <tiyash.basu@frequenz.com>
There was a problem hiding this comment.
Pull Request Overview
This PR introduces the v1alpha19 preview API for the Frequenz Microgrid service and updates related naming in the proto definitions and release notes.
- Adds a new
microgrid.protounderv1alpha19with updated RPCs and messages. - Renames the nested telemetry stream filter type and adjusts corresponding comments.
- Updates
RELEASE_NOTES.mdto referencev1alpha19and adjust upgrade instructions.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| proto/frequenz/api/microgrid/v1alpha19/microgrid.proto | Added new v1alpha19 package with updated service and messages |
| RELEASE_NOTES.md | Updated version references and upgrade instructions |
Comments suppressed due to low confidence (3)
proto/frequenz/api/microgrid/v1alpha19/microgrid.proto:71
- The comment mentions filtering by both sensor IDs and categories, but
ListSensorRequestonly provides asensor_idsfield. Please update or remove the category reference in the docs to match the actual request parameters.
//
proto/frequenz/api/microgrid/v1alpha19/microgrid.proto:352
- [nitpick] The request message is named
ListSensorRequestwhile the RPC isListSensors, and other list RPCs use plural in the request (ListElectricalComponentsRequest). Consider renaming this toListSensorsRequestfor consistency.
message ListSensorRequest {
RELEASE_NOTES.md:23
- The section header is present but the dependency update details that were in earlier releases have been removed. Please re-add any required dependency upgrade notes (e.g., protobuf, grpcio minimum versions) under this section.
## Upgrading to the `v0.19.0` release
Signed-off-by: Tiyash Basu <tiyash.basu@frequenz.com>
This commit renames the `ComponentTelemetryStreamFilter` message to `ElectricalComponentTelemetryStreamFilter` in the `v1alpha19` API. Additionall, this commit also updates the `RELEASE_NOTES.md` file to reflect the changes made in this release so far, including the introduction of the new `v1alpha19` API and the renaming of the telemetry stream filter. Signed-off-by: Tiyash Basu <tiyash.basu@frequenz.com>
5f089ad to
c39c4d4
Compare
llucax
approved these changes
Jul 17, 2025
Contributor
llucax
left a comment
There was a problem hiding this comment.
God dammit, how did we missed this one! 😆
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.