Bump protobuf-related dependencies#315
Merged
llucax merged 2 commits intofrequenz-floss:v0.17.xfrom Jun 11, 2025
Merged
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR bumps the protobuf-related dependencies and adjusts version ranges to ensure compatibility, while also updating the pytest configuration to ignore specific protobuf gencode warnings.
- Bumped dependency versions for protobuf, grpcio-tools, and grpcio.
- Updated dependency version ranges for frequenz-api-common and googleapis-common-protos.
- Added pytest settings to enforce verbose output and filter specific warning messages.
Comments suppressed due to low confidence (3)
pyproject.toml:40
- Verify that the updated protobuf version range (>= 6.31.1, < 8) meets all required compatibility guarantees for your codebase, given the change from the previous upper bound.
"protobuf >= 6.31.1, < 8", # Do not widen beyond 8!
pyproject.toml:44
- Confirm that the major version upgrade for grpcio does not introduce breaking changes in the components relying on it.
"grpcio >= 1.72.1, < 2", # Do not widen beyond 2!
pyproject.toml:153
- [nitpick] Consider adding a brief comment to explain why ignoring this specific warning is safe, which may help future maintainers understand the rationale.
'ignore:Protobuf gencode version .*exactly one major version older.*:UserWarning',
Contributor
Author
|
Same as #312 but for v0.17. |
Also ignore warnings about protobuf gencode version, as it is guaranteed by protobuf that 2 consecutive major versions are compatible. We are aware that after that we need to update the depencencies, and we'll get an error if we forget anyways. Signed-off-by: Leandro Lucarella <luca-frequenz@llucax.com>
Ubuntu 20.04 is no longer supported. Signed-off-by: Leandro Lucarella <luca-frequenz@llucax.com>
tiyash-basu-frequenz
approved these changes
Jun 11, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also ignore warnings about protobuf gencode version, as it is guaranteed by protobuf that 2 consecutive major versions are compatible. We are aware that after that we need to update the depencencies, and we'll get an error if we forget anyways.