Fix python dependencies for frequenz-api-common v0.6.0#235
Merged
tiyash-basu-frequenz merged 1 commit intofrequenz-floss:v0.x.xfrom Apr 10, 2024
Merged
Conversation
5f52a63 to
a8bb2a1
Compare
a8bb2a1 to
959dd38
Compare
In common API v0.6.0, the dependency on `googleapis-common-protos` has been removed in favor of internal `frequenz.api.common.v1.types.Decimal`. Signed-off-by: Tiyash Basu <tiyash.basu@frequenz.com>
959dd38 to
507b252
Compare
Marenz
approved these changes
Apr 9, 2024
llucax
reviewed
Apr 9, 2024
llucax
approved these changes
Apr 9, 2024
Contributor
llucax
left a comment
There was a problem hiding this comment.
I think it is not worth updating api-common because of this, so all good to merge from my side.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.