Add a new RPC for adding component bounds#229
Merged
tiyash-basu-frequenz merged 3 commits intofrequenz-floss:v0.x.xfrom Mar 27, 2024
Merged
Add a new RPC for adding component bounds#229tiyash-basu-frequenz merged 3 commits intofrequenz-floss:v0.x.xfrom
tiyash-basu-frequenz merged 3 commits intofrequenz-floss:v0.x.xfrom
Conversation
76ff6c9
b63ed44 to
76ff6c9
Compare
This new RPC accepts a list of inclusion bounds for a given metric. This input is then used by the service to populate the bounds in the published metric data. Signed-off-by: Tiyash Basu <tiyash.basu@frequenz.com>
These RPCs are not required anymore, sice the addition of RPC `AddComponentBounds`. Signed-off-by: Tiyash Basu <tiyash.basu@frequenz.com>
This enum has been removed in favour of the `Metric` enum from `frequenz-api-common`. Signed-off-by: Tiyash Basu <tiyash.basu@frequenz.com>
76ff6c9 to
77ec5cf
Compare
hannah-stevenson-frequenz
approved these changes
Mar 27, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #180