Return valid-until timestamps from set-power RPCs#183
Merged
tiyash-basu-frequenz merged 2 commits intofrequenz-floss:v0.x.xfrom Nov 22, 2023
Merged
Conversation
matthias-wende-frequenz
left a comment
There was a problem hiding this comment.
Looks good. I've only some minor comments about the documentation.
This commit allows the RPC `SetComponentPowerActive` to return a timestamp until which the given power command will stay in effect. After this timestamp, the component's active power will be set to 0, if the API receives no further command to change it before then. Typically, this timestamp will be set to the current time plus 60 seconds. Signed-off-by: Tiyash Basu <tiyash.basu@frequenz.com>
matthias-wende-frequenz
previously approved these changes
Nov 21, 2023
This commit allows the RPC `SetComponentPowerReactive` to return a timestamp until which the given power command will stay in effect. After this timestamp, the component's reactive power will be set to 0, if the API receives no further command to change it before then. Typically, this timestamp will be set to the current time plus 60 seconds. Signed-off-by: Tiyash Basu <tiyash.basu@frequenz.com>
2414f0b to
65413aa
Compare
Contributor
Author
|
Needs another approval after rebase. |
llucax
approved these changes
Nov 22, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The RPCs to set power now return timestamps until which the command will stay in effect. The component's active/reactive power will be set to 0 after this timestamp, if the API receives no further requests to change it before then.
By default, this timestamp will be the current time plus 60 seconds.