Update frequenz-api-common to v0.5.0#173
Merged
tiyash-basu-frequenz merged 2 commits intofrequenz-floss:v0.x.xfrom Nov 10, 2023
Merged
Update frequenz-api-common to v0.5.0#173tiyash-basu-frequenz merged 2 commits intofrequenz-floss:v0.x.xfrom
tiyash-basu-frequenz merged 2 commits intofrequenz-floss:v0.x.xfrom
Conversation
5c226a3 to
94b1db9
Compare
94b1db9 to
1732aa6
Compare
5b9abf2 to
24d9f3a
Compare
ef094c4 to
ba87aaf
Compare
llucax
reviewed
Nov 10, 2023
Contributor
llucax
left a comment
There was a problem hiding this comment.
You probably want to also update the mkdocs.yml file (maybe also do a git grep api-common to make sure we are not missing any other reference?
ba87aaf to
05d51fc
Compare
Contributor
|
I guess you didn't saw the review comment above?
GitHub should really do something about those review comments, they are very easy to miss and I just realized they don't even have a way to put a link to them! |
This commit upgrades the common protobuf dependency to v0.5.0. The protobuf messages returned by the RPCs are now in the `frequenz.api.common.v1` package. As a result, all files besides microgrid.proto have become obsolete, and have been removed. Signed-off-by: Tiyash Basu <tiyash.basu@frequenz.com>
After upgrading to v0.5.0 of frequenz-api-common, a few older release notes became obsolete, and therefore, have been removed. Signed-off-by: Tiyash Basu <tiyash.basu@frequenz.com>
05d51fc to
56090e8
Compare
Contributor
Author
You are right, I missed it. It was a good suggestion though. I fixed the line you had linked. Plus, I also found another line in the release notes that referred to v0.3, and removed it. |
llucax
approved these changes
Nov 10, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.