Remove sensors from component category and represent the separately#145
Merged
tiyash-basu-frequenz merged 4 commits intofrequenz-floss:v0.x.xfrom Oct 4, 2023
Merged
Conversation
5c97e98 to
d366d5c
Compare
thomas-nicolai-frequenz
previously approved these changes
Oct 2, 2023
thomas-nicolai-frequenz
left a comment
There was a problem hiding this comment.
All good from my side. We should however, clarify that when we say components we mean electrical components!
7cc7316 to
a6f464f
Compare
Contributor
Author
@thomas-nicolai-frequenz I added another commit to re-inforce components as electrical components. Ready for another look. |
thomas-nicolai-frequenz
previously approved these changes
Oct 2, 2023
a6f464f to
d06f500
Compare
stefan-brus-frequenz
left a comment
There was a problem hiding this comment.
Looks pretty good overall, with one reservation
Signed-off-by: Tiyash Basu <tiyash.basu@frequenz.com>
The messages have been organised in a more logical way, in the following order: * components * connections * parameters for setting power levels * parameters for setting bounds * parameters for setting component states Signed-off-by: Tiyash Basu <tiyash.basu@frequenz.com>
The change aims to clarify the distinction between electrical components (e.g., inverters, batteries) and sensors (e.g., temperature, humidity). This commit introduces a new RPC method for listing sensors in the microgrid, effectively separating them from the "component" category. This allows for more granular control and filtering of sensors by ID and category. Additionally, a new RPC method for subscribing to sensor data is introduced. Signed-off-by: Tiyash Basu <tiyash.basu@frequenz.com>
In this change, componentts are re-inforced as electrical components, in the light of the new sensor RPCs. Signed-off-by: Tiyash Basu <tiyash.basu@frequenz.com>
d06f500 to
6b75e8f
Compare
stefan-brus-frequenz
approved these changes
Oct 4, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This update introduces a dedicated RPC method for listing sensors in the microgrid, separating them from the "component" category. This new method allows for optional sensor filtering by ID or category. The change clarifies the term "component" to exclusively refer to electrical equipment like inverters and batteries, while sensors are now treated as a distinct entity.