Add new sensor category and metric enums#93
Add new sensor category and metric enums#93tiyash-basu-frequenz merged 1 commit intofrequenz-floss:v0.x.xfrom
Conversation
3205db4 to
4d5ffc3
Compare
There was a problem hiding this comment.
LGTM, but it is missing the This is just adding one file, I was confused by the text in the PR description "This commit adds the py/frequenz/api/common/v1/sensors/__init__.py (I assume this will be rebased on top of the PR adding the v1 :) ).frequenz.api.common.sensors package".
4d5ffc3 to
2eff98b
Compare
In our terminology, `components` are the devices that are connected to a microgrid's electrical circuit, and `sensors` are the devices that measure the physical parameters of the environment. Hence, we need to distinguish between the two, and we need to be able to identify the type of sensor and the type of metric that it measures. This commit adds the `frequenz.api.common,v1.sensors` package, which contains the `SensorCategory` and `SensorMetric` enums. Also, this commit removes * the `COMPONENT_CATEGORY_SENSOR` variant from the `ComponentCategory` enum, and * The `SensorType` enum. Signed-off-by: Tiyash Basu <tiyash.basu@frequenz.com>
2eff98b to
8cb9bcc
Compare
Good point. Fixed. |
llucax
left a comment
There was a problem hiding this comment.
Mmm, I still see package everywhere, but I'm not sure if this is even wrong in the protobuf world (in Python packages are like directories, that contain modules, which are files). So approving because I don't think it is important really.
|
I assume you mean how we declare package names in protobuf files? Declaring |
In our terminology,
componentsare the devices that are connected to a microgrid's electrical circuit, andsensorsare the devices that measure the physical parameters of the environment.Hence, we need to distinguish between the two, and we need to be able to identify the type of sensor and the type of metric that it measures.
This commit adds the
frequenz.api.common.v1.sensorspackage, which contains theSensorCategoryandSensorMetricenums.Also, this commit removes
COMPONENT_CATEGORY_SENSORvariant from theComponentCategoryenum, andSensorTypeenum.