Add model field to ElectricalComponent and Sensor messages#469
Conversation
51e173d to
81f9cf0
Compare
llucax
left a comment
There was a problem hiding this comment.
LGTM, but I would keep the field IDs sorted, otherwise I think things can get very error prone if one needs to manually grep the whole message to see what's the latest/highest ID when a new field needs to be added.
|
Hehe, that got officially confirmed, the current CI failure is actually because you got the ID wrong:
|
81f9cf0 to
a436566
Compare
True, not having them sorted is what caused the issue. |
a436566 to
c854a12
Compare
This commit adds a new field `model` to the `ElectricalComponent` and `Sensor` messages in the proto files. The `model` field includes both the manufacturer and the model name of the component or sensor. Typically, the existing fields `manufacturer` and `model_name` are not used in separate contexts, despite being present in the structure for years. The new `model` field provides a more concise way to represent the model information, which is often used in practice. Signed-off-by: Tiyash Basu <tiyash.basu@frequenz.com>
This commit deprecates the existing `manufacturer` and `model_name` fields in the `ElectricalComponent` and `Sensor` messages in favor of the new `model` field that includes both the manufacturer and the model name. This change is made to communicate to users that these fields should no longer be used and to encourage users to switch to the new `model` field. Signed-off-by: Tiyash Basu <tiyash.basu@frequenz.com>
c854a12 to
2e4e95d
Compare
This PR adds a new field
modelto theElectricalComponentandSensormessages in the proto files. Themodelfield includes both the manufacturer and the model name of the component or sensor.Typically, the existing fields
manufacturerandmodel_nameare not used in separate contexts, despite being present in the structure for years. The newmodelfield provides a more concise way to represent the model information, which is often used in practice.In addition to the above, this PR deprecates the existing fields
manufacturerandmodel_name, and these fields be removed in the next breaking change release.