Add protobuf definition for communication components#292
Conversation
Signed-off-by: Tar Viturawong <thanatip.viturawong@frequenz.com>
llucax
left a comment
There was a problem hiding this comment.
Not sure if this was discussed anywhere, but I find it confusing that communication components are called components but have nothing to do with the existing Component. Can we name them differently to avoid confusion?
Does this mean the microgrid API will get a new RPC for listing and getting these new type of devices as we have for components and sensors? A bit more context of where this is coming from would be useful.
|
Oh, I see #291 now. |
|
Thanks @tar-viturawong-frequenz. Could you please add an entry to the RELEASE_NOTES file as well? |
@llucax Unfortunately this is not a decision that I can change on my own. The term |
Yeah, all good, I didn't see that we were renaming component -> electrical_component when I wrote that, and wasn't aware this was coming up, this is why I was a bit surprised. But with the rename, it make sense. |
Signed-off-by: Tar Viturawong <thanatip.viturawong@frequenz.com>
b73db37 to
e30300c
Compare
llucax
left a comment
There was a problem hiding this comment.
LGTM but leaving the approval to @tiyash-basu-frequenz
tiyash-basu-frequenz
left a comment
There was a problem hiding this comment.
Looks great. I just have a few nits and one date related comment.
34b3f9c to
41002f0
Compare
| def test_module_import_microgrid_communication_components() -> None: | ||
| """Test that the modules can be imported.""" | ||
| # pylint: disable=import-outside-toplevel | ||
| from frequenz.api.common.v1.microgrid import communication_components |
There was a problem hiding this comment.
This should be communication_components_pb2.
Signed-off-by: Tar Viturawong <thanatip.viturawong@frequenz.com>
Signed-off-by: Tar Viturawong <thanatip.viturawong@frequenz.com>
79d236a to
9ee3a11
Compare
Signed-off-by: Tar Viturawong <thanatip.viturawong@frequenz.com>
Signed-off-by: Tar Viturawong <134121305+tar-viturawong-frequenz@users.noreply.github.com>
No description provided.