Skip to content

Move conftest.py to the python package root#252

Merged
llucax merged 2 commits intofrequenz-floss:v0.x.xfrom
llucax:mv-conftest
Sep 13, 2024
Merged

Move conftest.py to the python package root#252
llucax merged 2 commits intofrequenz-floss:v0.x.xfrom
llucax:mv-conftest

Conversation

@llucax
Copy link
Copy Markdown
Contributor

@llucax llucax commented Sep 12, 2024

This is mostly to make it easier to navigate to the root of the package.

We also fix its location in MANIFEST.in to ensure it is excluded from the binary distribution.

The `conftest.py` file was wrongly included in the binary distribution.

Signed-off-by: Leandro Lucarella <luca-frequenz@llucax.com>
This is mostly to make it easier to navigate to the root of the package.

Signed-off-by: Leandro Lucarella <luca-frequenz@llucax.com>
@llucax llucax requested a review from a team as a code owner September 12, 2024 10:57
@llucax llucax requested a review from cyiallou September 12, 2024 10:57
@llucax llucax self-assigned this Sep 12, 2024
@llucax llucax added this to the v0.7.0 milestone Sep 12, 2024
@github-actions github-actions Bot added part:python Affects the Python bindings part:tests Affects the unit, integration and performance (benchmarks) tests part:tooling Affects the development tooling (CI, deployment, dependency management, etc.) labels Sep 12, 2024
@llucax llucax added type:bug Something isn't working type:tech-debt Improves the project without visible changes for users labels Sep 12, 2024
@llucax llucax enabled auto-merge September 12, 2024 10:58
@tiyash-basu-frequenz
Copy link
Copy Markdown
Contributor

Does this need a release note? LGTM otherwise

@llucax
Copy link
Copy Markdown
Contributor Author

llucax commented Sep 13, 2024

Nah, this is just internal (or fix a bug in the distribution package, but I think it's mostly noise, I don't think any user will care). Skipping release notes.

@llucax llucax added the cmd:skip-release-notes It is not necessary to update release notes for this PR label Sep 13, 2024
@llucax llucax added this pull request to the merge queue Sep 13, 2024
Merged via the queue into frequenz-floss:v0.x.x with commit ca56060 Sep 13, 2024
@llucax llucax deleted the mv-conftest branch September 13, 2024 07:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cmd:skip-release-notes It is not necessary to update release notes for this PR part:python Affects the Python bindings part:tests Affects the unit, integration and performance (benchmarks) tests part:tooling Affects the development tooling (CI, deployment, dependency management, etc.) type:bug Something isn't working type:tech-debt Improves the project without visible changes for users

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants