Move conftest.py to the python package root#252
Merged
llucax merged 2 commits intofrequenz-floss:v0.x.xfrom Sep 13, 2024
Merged
Move conftest.py to the python package root#252llucax merged 2 commits intofrequenz-floss:v0.x.xfrom
conftest.py to the python package root#252llucax merged 2 commits intofrequenz-floss:v0.x.xfrom
Conversation
The `conftest.py` file was wrongly included in the binary distribution. Signed-off-by: Leandro Lucarella <luca-frequenz@llucax.com>
This is mostly to make it easier to navigate to the root of the package. Signed-off-by: Leandro Lucarella <luca-frequenz@llucax.com>
Contributor
|
Does this need a release note? LGTM otherwise |
tiyash-basu-frequenz
approved these changes
Sep 12, 2024
Contributor
Author
|
Nah, this is just internal (or fix a bug in the distribution package, but I think it's mostly noise, I don't think any user will care). Skipping release notes. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is mostly to make it easier to navigate to the root of the package.
We also fix its location in
MANIFEST.into ensure it is excluded from the binary distribution.