chore(upgrade): v1.5.0 to v1.6.0#2046
Merged
enddynayn merged 1 commit intoJun 28, 2024
Merged
Conversation
ab9952e to
3fd02fc
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
|
326382b to
be21de8
Compare
be21de8 to
c558481
Compare
ee60b82 to
091e0e8
Compare
shannonwells
approved these changes
Jun 27, 2024
shannonwells
left a comment
Collaborator
There was a problem hiding this comment.
Seems good to go. I did not look through the substrate pallet weight changes. I did look through our custom pallet weight changes. The biggest differences that I noticed were lowered weights.
091e0e8 to
9e982d0
Compare
wilwade
reviewed
Jun 28, 2024
wilwade
reviewed
Jun 28, 2024
|
|
||
| /// Export the genesis state of the parachain. | ||
| ExportGenesisState(cumulus_client_cli::ExportGenesisStateCommand), | ||
| #[command(alias = "export-genesis-state")] |
wilwade
approved these changes
Jun 28, 2024
wilwade
left a comment
Collaborator
There was a problem hiding this comment.
One non-blocking unused dependency removal and the e2e test needing a decreased amount due to the lower cost
- Reviewed code
9e982d0 to
83a4123
Compare
- Upgrade Polkadot-sdk to v.1.6.0. - Update weights to reflect the new version. - Modify extrinsic weight test due to an improvement in weights. Notable Changes: - [Rename ExportGenesisStateCommand to ExportGenesisHeadCommand ](paritytech/polkadot-sdk#2331) For more details, please refer to: [Release Notes](https://github.com/paritytech/polkadot-sdk/releases/tag/polkadot-v1.6.0) [Release Analysis](https://forum.polkadot.network/t/polkadot-release-analysis-v1-6-0/58550) issue-1841
83a4123 to
236ac96
Compare
mattheworris
approved these changes
Jun 28, 2024
mattheworris
left a comment
Collaborator
There was a problem hiding this comment.
- Read through changes
Nice work!
🚢 it!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Notable Changes:
For more details, please refer to:
Release Notes
Release Analysis
#1841