Skip to content

Set defaults for some fields#417

Merged
frenck merged 1 commit intomainfrom
frenck-2023-1395
Nov 7, 2023
Merged

Set defaults for some fields#417
frenck merged 1 commit intomainfrom
frenck-2023-1395

Conversation

@frenck
Copy link
Owner

@frenck frenck commented Nov 7, 2023

Proposed Changes

Some of these fields need a default.

@frenck frenck added the bugfix Inconsistencies or issues which will cause a problem for users or implementers. label Nov 7, 2023
@codecov-commenter
Copy link

codecov-commenter commented Nov 7, 2023

Codecov Report

Merging #417 (5a2295e) into main (8698dbf) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main     #417   +/-   ##
=======================================
  Coverage   94.89%   94.89%           
=======================================
  Files           4        4           
  Lines         294      294           
  Branches       17       17           
=======================================
  Hits          279      279           
  Misses         11       11           
  Partials        4        4           
Files Coverage Δ
src/open_meteo/models.py 100.00% <100.00%> (ø)

@sonarqubecloud
Copy link

sonarqubecloud bot commented Nov 7, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@frenck frenck merged commit 1c4bd20 into main Nov 7, 2023
@frenck frenck deleted the frenck-2023-1395 branch November 7, 2023 19:36
@github-actions github-actions bot locked and limited conversation to collaborators Nov 9, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

bugfix Inconsistencies or issues which will cause a problem for users or implementers.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants