Skip to content

chore: migrate to @chainsafe/is-ip#21

Merged
frenchbread merged 3 commits intofrenchbread:masterfrom
twoeths:tuyen/is_ip_4.0.0
Nov 13, 2022
Merged

chore: migrate to @chainsafe/is-ip#21
frenchbread merged 3 commits intofrenchbread:masterfrom
twoeths:tuyen/is_ip_4.0.0

Conversation

@twoeths
Copy link
Copy Markdown
Contributor

@twoeths twoeths commented Oct 28, 2022

Motivation

  • is-ip 4.0.0 is the last performant version of is-ip (version 5.0.0 has a performance issue)
  • use @chainsafe/is-ip which is significantly faster

Description
Migrate to is-ip 4.0.0
Migrate to @chainsafe/is-ip

@wemeetagain
Copy link
Copy Markdown

@tuyennhv can you use @chainsafe/is-ip v2.0.1?

@twoeths
Copy link
Copy Markdown
Contributor Author

twoeths commented Nov 1, 2022

migrated to @chainsafe/is-ip as it's significantly faster, see ChainSafe/is-ip#1

@twoeths twoeths changed the title chore: migrate to is-ip 4.0.0 chore: migrate to @chainsafe/is-ip Nov 1, 2022
@frenchbread
Copy link
Copy Markdown
Owner

frenchbread commented Nov 9, 2022

Thanks @tuyennhv & @wemeetagain a lot for the contribution!

@chainsafe/is-ip appears to be an ESM module which private-ip does not support at this point. Would you mind converting this package to esm package? (reference pure ESM). Preferably supporting both cjs & esm.

@frenchbread
Copy link
Copy Markdown
Owner

Great work, thanks!

@frenchbread frenchbread merged commit ab988d1 into frenchbread:master Nov 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants