keep Netmask map results around, instead of re-computing each time#13
Merged
frenchbread merged 1 commit intofrenchbread:masterfrom Apr 16, 2021
newhouse:newhouse/v4-range-efficiency
Merged
keep Netmask map results around, instead of re-computing each time#13frenchbread merged 1 commit intofrenchbread:masterfrom newhouse:newhouse/v4-range-efficiency
frenchbread merged 1 commit intofrenchbread:masterfrom
newhouse:newhouse/v4-range-efficiency
Conversation
Owner
|
Thanks for the PR, @newhouse. Merging. |
Contributor
Author
|
You're welcome! Any idea when you'll publish a new version with this change? I'd like to update my package... |
Owner
|
@newhouse, |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It seemed unnecessary / inefficient to build up the
blocksarray during each call toipv4_check.This change builds the
Netmaskarray map, and keeps it around for re-use during eachipv4_checkcall.