Conversation
This comment was marked as resolved.
This comment was marked as resolved.
9fb6d83 to
d9a0687
Compare
Signed-off-by: weeman <weeman@frankfurt.ccc.de>
Signed-off-by: weeman <weeman@frankfurt.ccc.de>
Add ESLint to scripts. Make polyfill ESLint compliant. Signed-off-by: weeman <weeman@frankfurt.ccc.de>
ae7f076 to
820793f
Compare
820793f to
175c44c
Compare
MyIgel
left a comment
There was a problem hiding this comment.
That setup works so great! 😍
Some preliminary findings:
-
npm install shows warnings, can they easily be fixed?
npm WARN deprecated @stylelint/postcss-markdown@0.36.2: Use the original unforked package instead: postcss-markdown npm WARN deprecated sourcemap-codec@1.4.8: Please use @jridgewell/sourcemap-codec instead npm WARN deprecated rollup-plugin-terser@7.0.2: This package has been deprecated and is no longer maintained. Please use @rollup/plugin-terser npm WARN deprecated @stylelint/postcss-css-in-js@0.37.3: Package no longer supported. Contact Support at https://www.npmjs.com/support for more info. npm WARN deprecated babel-eslint@10.1.0: babel-eslint is now @babel/eslint-parser. This package will no longer receive updates. -
There seem to be some possible moderate vulnerabilities, are they easily fixable?
-
When opening a node the left side panel is blank and the console shows an error.
-
When opening the node graph, the page seems to work but shows an error in the console
either way it might have been easier to recview if the linting vs migration would have been two MRs ;)
MyIgel
left a comment
There was a problem hiding this comment.
Those "fixes" might fix the above errors but might be implemented somehow better, dunno :D
Also I'm wondering if there is an easy option to keep the whole graph centred all the time, even before it gets rescaled to zoom to a specific node?
See https://github.com/sasstools/sass-lint Signed-off-by: weeman <weeman@frankfurt.ccc.de>
175c44c to
00b907e
Compare
Signed-off-by: weeman <weeman@frankfurt.ccc.de>
00b907e to
b113ad7
Compare
MyIgel
left a comment
There was a problem hiding this comment.
That looks better, just a small hickup:
This comment was marked as resolved.
This comment was marked as resolved.
b113ad7 to
8e06242
Compare
8e06242 to
2417eea
Compare
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
|
Danke @weeman1337 |
closes #13
Description + Motivation and Context
This PR migrates the build system from Gulp to Vite. Gulp is rarely maintained, the packages become outdated and it becomes more and more problematic to keep the dependencies up to date. Good example are the overrides to „fix“ the dependencies security issues.
Because this PR touches every file anyway 🤷 It also introduces Prettier for a consistent code-style.
How Has This Been Tested?
Tested builds locally.
Screenshots/links:
No user-facing change
Checklist: