Merged
Conversation
maxZoom was missing when using vectore
3 tasks
maurerle
approved these changes
Mar 2, 2026
Member
|
Looks good - I would like to rebase onto main to get the CI pass. I tested it locally and will just merge this line. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
maxZoomwas missing when using vectorestill missing is
orderandmode(for nightmode)Motivation and Context
How Has This Been Tested?
Tested via Codespaces
npm installandnpm run devand custom vectore tiles config:https://github.com/freifunkMUC/meshviewer/tree/test-vectore
Screenshots/links:
layers array bevor:
[ { "name": "versatiles light", "layer": { "options": { "style": "light.json", "attributionControl": { "customAttribution": "<a href='https://github.com/freifunk/meshviewer/issues' target='_blank'>Report Bug</a> | Map data © <a href\"http://openstreetmap.org\">OpenStreetMap</a> contributor" } }, "_initHooksCalled": true } }, { "name": "versatiles dark", "layer": { "options": { "style": "dark.json", "attributionControl": { "customAttribution": "<a href='https://github.com/freifunk/meshviewer/issues' target='_blank'>Report Bug</a> | Map data © <a href\"http://openstreetmap.org\">OpenStreetMap</a> contributor" } }, "_initHooksCalled": true } }, { "name": "FFMUC OSM Proxy", "layer": { "options": { "maxZoom": 19, "attribution": "© Openstreetmap | © <a href=\"http://www.openstreetmap.org/copyright\">OpenStreetMap</a>", "order": 2, "subdomains": [ "a", "b", "c" ] }, "_url": "https://tiles.ext.ffmuc.net/osm/{z}/{x}/{y}.png", "_events": { "tileunload": [ {} ] }, "_initHooksCalled": true } }, { "name": "FFMUC OSM Proxy (Night)", "layer": { "options": { "maxZoom": 19, "mode": "night", "attribution": "© Openstreetmap | © <a href=\"http://www.openstreetmap.org/copyright\">OpenStreetMap</a>", "order": 3, "subdomains": [ "a", "b", "c" ] }, "_url": "https://tiles.ext.ffmuc.net/osm/{z}/{x}/{y}.png", "_events": { "tileunload": [ {} ] }, "_initHooksCalled": true } }, { "name": "FFMUC OSM.HOT Proxy", "layer": { "options": { "maxZoom": 20, "attribution": "© Openstreetmap France | © <a href=\"http://www.openstreetmap.org/copyright\">OpenStreetMap</a>", "order": 4, "subdomains": [ "a", "b", "c" ] }, "_url": "https://tiles.ext.ffmuc.net/hot/{z}/{x}/{y}.png", "_events": { "tileunload": [ {} ] }, "_initHooksCalled": true } }, { "name": "Esri.WorldImagery", "layer": { "options": { "maxZoom": 20, "attribution": "Tiles © Esri — Source: Esri, i-cubed, USDA, USGS, AEX, GeoEye, Getmapping, Aerogrid, IGN, IGP, UPR-EGP, and the GIS User Community", "order": 5, "subdomains": [ "a", "b", "c" ] }, "_url": "//server.arcgisonline.com/ArcGIS/rest/services/World_Imagery/MapServer/tile/{z}/{y}/{x}", "_events": { "tileunload": [ {} ] }, "_initHooksCalled": true } } ]layers array now:
[ { "name": "versatiles light", "layer": { "options": { "style": "light.json", "attributionControl": { "customAttribution": "<a href='https://github.com/freifunk/meshviewer/issues' target='_blank'>Report Bug</a> | Map data © <a href\"http://openstreetmap.org\">OpenStreetMap</a> contributor" }, "maxZoom": 19 }, "_initHooksCalled": true } }, { "name": "versatiles dark", "layer": { "options": { "style": "dark.json", "attributionControl": { "customAttribution": "<a href='https://github.com/freifunk/meshviewer/issues' target='_blank'>Report Bug</a> | Map data © <a href\"http://openstreetmap.org\">OpenStreetMap</a> contributor" }, "maxZoom": 19 }, "_initHooksCalled": true } }, { "name": "FFMUC OSM Proxy", "layer": { "options": { "maxZoom": 19, "attribution": "© Openstreetmap | © <a href=\"http://www.openstreetmap.org/copyright\">OpenStreetMap</a>", "order": 2, "subdomains": [ "a", "b", "c" ] }, "_url": "https://tiles.ext.ffmuc.net/osm/{z}/{x}/{y}.png", "_events": { "tileunload": [ {} ] }, "_initHooksCalled": true } }, { "name": "FFMUC OSM Proxy (Night)", "layer": { "options": { "maxZoom": 19, "mode": "night", "attribution": "© Openstreetmap | © <a href=\"http://www.openstreetmap.org/copyright\">OpenStreetMap</a>", "order": 3, "subdomains": [ "a", "b", "c" ] }, "_url": "https://tiles.ext.ffmuc.net/osm/{z}/{x}/{y}.png", "_events": { "tileunload": [ {} ] }, "_initHooksCalled": true } }, { "name": "FFMUC OSM.HOT Proxy", "layer": { "options": { "maxZoom": 20, "attribution": "© Openstreetmap France | © <a href=\"http://www.openstreetmap.org/copyright\">OpenStreetMap</a>", "order": 4, "subdomains": [ "a", "b", "c" ] }, "_url": "https://tiles.ext.ffmuc.net/hot/{z}/{x}/{y}.png", "_events": { "tileunload": [ {} ] }, "_initHooksCalled": true } }, { "name": "Esri.WorldImagery", "layer": { "options": { "maxZoom": 20, "attribution": "Tiles © Esri — Source: Esri, i-cubed, USDA, USGS, AEX, GeoEye, Getmapping, Aerogrid, IGN, IGP, UPR-EGP, and the GIS User Community", "order": 5, "subdomains": [ "a", "b", "c" ] }, "_url": "//server.arcgisonline.com/ArcGIS/rest/services/World_Imagery/MapServer/tile/{z}/{y}/{x}", "_events": { "tileunload": [ {} ] }, "_initHooksCalled": true } } ]setting breakpoints works good to get all the infos
without zoom:
with zoom:
