cleanup code and fix default of deep links in generateLink function#266
Merged
skorpy2009 merged 1 commit intomainfrom Dec 29, 2025
Merged
cleanup code and fix default of deep links in generateLink function#266skorpy2009 merged 1 commit intomainfrom
skorpy2009 merged 1 commit intomainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #262
This was introduced with the updated navigo router in #132
introduces a new deepUrl function instead of calling the fullUrl function in a way which produces a deepUrl.
Using
generateLinkto create links which are neither full nor deep is not used anywhere.