Conversation
GoliathLabs
approved these changes
Jul 28, 2025
maurerle
commented
Jul 30, 2025
Member
Author
maurerle
left a comment
There was a problem hiding this comment.
I will add docs to this
grische
reviewed
Jul 31, 2025
grische
reviewed
Jul 31, 2025
| # Project files | ||
| /node_modules | ||
| /build | ||
| /config.json |
Contributor
There was a problem hiding this comment.
This should really stay here, shouldn't it?
Member
Author
There was a problem hiding this comment.
The public/config.json is the one which is copied to build/config.json during build - so there is no use for /config.json (except for causing confusion)
Member
Author
There was a problem hiding this comment.
For FreifunkMUC this is copied after build into the build folder:
https://github.com/freifunkMUC/meshviewer/blob/main/.github/workflows/deploy.yaml#L23
So this change should be fine.
Contributor
|
Somewhat related: I've suggested some changes to the Dockerfile, such as removing npm audit, as this should be in a separate dev environment rather than in the Dockerfile itself: #196 |
28525b5 to
4a0b084
Compare
docker compose build docker compose up -d docker compose down
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This adds simple testing capabilities with docker using docker compose
How Has This Been Tested?
Screenshots/links:
Checklist: