fix: calculate stats on all nodes#187
Merged
rotanid merged 1 commit intofreifunk:mainfrom Jul 25, 2025
Merged
Conversation
before, the nodes used for the stats were only all online plus lost nodes. This amount is filtered by maxage, which is confusing and unexpected
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
before, the nodes used for the stats were only all online plus lost nodes. This amount is filtered by maxage, which is confusing and unexpected
This led to issues at @freifunkh, as they do not have a matching age filter in yanic to their meshviewer config.
The
maxAgeconfig param now only filters the "new Nodes" and "disappeared Nodes" view.Motivation and Context
This issue also exists on graveyard configs, which do not limit the old nodes
How Has This Been Tested?
Run code locally using
npm run devandnpm run buildScreenshots/links:
Checklist: