Skip to content

fix: calculate stats on all nodes#187

Merged
rotanid merged 1 commit intofreifunk:mainfrom
maurerle:calc_stats_on_all_nodes
Jul 25, 2025
Merged

fix: calculate stats on all nodes#187
rotanid merged 1 commit intofreifunk:mainfrom
maurerle:calc_stats_on_all_nodes

Conversation

@maurerle
Copy link
Member

@maurerle maurerle commented Jul 25, 2025

Description

before, the nodes used for the stats were only all online plus lost nodes. This amount is filtered by maxage, which is confusing and unexpected

This led to issues at @freifunkh, as they do not have a matching age filter in yanic to their meshviewer config.

The maxAge config param now only filters the "new Nodes" and "disappeared Nodes" view.

Motivation and Context

This issue also exists on graveyard configs, which do not limit the old nodes

How Has This Been Tested?

Run code locally using npm run dev and npm run build

Screenshots/links:

Checklist:

  • My code follows the code style of this project. (CI will test it anyway and also needs approval)
  • My change requires a change to the documentation.
    • I have updated the documentation accordingly.

before, the nodes used for the stats were only all online plus lost nodes.
This amount is filtered by maxage, which is confusing and unexpected
@maurerle maurerle requested review from MyIgel and skorpy2009 July 25, 2025 20:12
@rotanid rotanid merged commit 074e9c8 into freifunk:main Jul 25, 2025
2 checks passed
@maurerle maurerle deleted the calc_stats_on_all_nodes branch July 25, 2025 21:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants