Merged
Conversation
Contributor
|
Why don't we switch to dark mode automatically? Most user (e.g. me) didn't know of this feature yet. |
Member
Author
|
Because it is not implemented :D i tried to this last year but somehow could not figure it out. So if you want to try a PR, go ahead :) But yes, would be good in general! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This readds the night-mode as before
860cdd9#diff-0eb547304658805aad788d320f10bf1f292797b5e6d745a3bf617584da017051L28
it does not automatically switch with:
window.matchMedia("(prefers-color-scheme: dark)").Motivation and Context
fixes #97
How Has This Been Tested?
Toggling between a theme with and without
"mode": "night",set.Screenshots/links:
The svg is not inverted, everything else works like before.
Checklist: