[TASK] switch to ecmascript modules#131
Merged
MyIgel merged 2 commits intofreifunk:mainfrom Jan 18, 2025
Merged
Conversation
added 2 commits
January 17, 2025 20:32
The `attrs` parameter doesn't seem to work anymore, `props` does. Also using the return type of patch is generally not needed, since patch mutates the node itself
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
I have converted the project to use ecmascript modules. It was necessary to update the rbush and snabbdom dependencies to make this work.
There was also a small bug i fixed here. Not sure if this was introduced with my changes, or beforehand.
Motivation and Context
Keep the project up to date and stop vite from nagging about it
How Has This Been Tested?
So far i have only tested this in Firefox 134, but given the nature of the change i suspect that it wont have any impact. I have clicked through every menu and didn't observe any change in behavior compared to the previous version.
Screenshots/links:
https://vite.dev/guide/troubleshooting.html#vite-cjs-node-api-deprecated
Checklist: