Skip to content

refactor: Rename precompiles benchmark under precompiles-benchmark-pallet#960

Merged
magecnion merged 3 commits intomainfrom
refactor/move-precompiles-benchmark-to-pallet-benchmark
Jan 24, 2025
Merged

refactor: Rename precompiles benchmark under precompiles-benchmark-pallet#960
magecnion merged 3 commits intomainfrom
refactor/move-precompiles-benchmark-to-pallet-benchmark

Conversation

@tsenovilla
Copy link
Copy Markdown
Contributor

@tsenovilla tsenovilla commented Jan 21, 2025

This PR aims to improve the code quality of our repo by refactoring the names of the precompiles call under the precompiles-benchmark pallet, following the schema precompile_pallet_extrinsic so we will prevent future collisions in case we include new precompiles under this pallet.

We also include this pallet in the runtime only if we're running benchmarks

@tsenovilla tsenovilla linked an issue Jan 21, 2025 that may be closed by this pull request
@tsenovilla tsenovilla changed the title refactor: Move precompiles under precompiles benchmark pallet refactor: Move precompiles under precompiles umbrella crate Jan 21, 2025
@tsenovilla tsenovilla marked this pull request as ready for review January 22, 2025 10:31
@tsenovilla tsenovilla changed the title refactor: Move precompiles under precompiles umbrella crate refactor: Rename precompiles benchmark under precompiles-benchmark-pallet Jan 22, 2025
@magecnion magecnion merged commit 9d49185 into main Jan 24, 2025
@magecnion magecnion deleted the refactor/move-precompiles-benchmark-to-pallet-benchmark branch January 24, 2025 09:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Rename and Structure Precompiles for Better Organization

3 participants