Skip to content

fix: removing line from skyline project level 18#46865

Merged
Sboonny merged 1 commit intofreeCodeCamp:mainfrom
sagivab:issue-46845
Jul 12, 2022
Merged

fix: removing line from skyline project level 18#46865
Sboonny merged 1 commit intofreeCodeCamp:mainfrom
sagivab:issue-46845

Conversation

@sagivab
Copy link
Copy Markdown
Contributor

@sagivab sagivab commented Jul 12, 2022

Checklist:

  • I have read freeCodeCamp's contribution guidelines.
  • My pull request has a descriptive title (not a vague title like Update index.md)
  • My pull request targets the main branch of freeCodeCamp.
  • I have tested these changes either locally on my machine, or GitPod.

Closes #46845

@gitpod-io
Copy link
Copy Markdown

gitpod-io bot commented Jul 12, 2022

@github-actions github-actions bot added the scope: curriculum Lessons, Challenges, Projects and other Curricular Content in curriculum directory. label Jul 12, 2022
@ghost
Copy link
Copy Markdown

ghost commented Jul 12, 2022

👀 Review this PR in a CodeSee Review Map

View the CodeSee Map of this change

Review these changes using an interactive CodeSee Map

Legend

CodeSee Map Legend

Sboonny
Sboonny approved these changes Jul 12, 2022
View reviewed changes
Copy link
Copy Markdown
Member

@Sboonny Sboonny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✨ 🎉 AWESOME! 🎉 ✨

Hi @sagivab, thanks for this pull request and for contributing to the code-base for the first time. We are looking forward to more contributions from you in the future.

Cheers & happy contributing!

@Sboonny Sboonny enabled auto-merge (squash) July 12, 2022 06:05
@Sboonny Sboonny added the status: waiting review To be applied to PR's that are ready for QA, especially when additional review is pending. label Jul 12, 2022
@jdwilkin4 jdwilkin4 changed the title delete Let's make some more! text from skyline project level #18 page. fix: removing line from skyline project level 18 Jul 12, 2022
jdwilkin4
jdwilkin4 approved these changes Jul 12, 2022
View reviewed changes
Copy link
Copy Markdown
Contributor

@jdwilkin4 jdwilkin4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 👍

@Sboonny Sboonny merged commit b07460c into freeCodeCamp:main Jul 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jdwilkin4 jdwilkin4 jdwilkin4 approved these changes

+1 more reviewer

@Sboonny Sboonny Sboonny approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

scope: curriculum Lessons, Challenges, Projects and other Curricular Content in curriculum directory. status: waiting review To be applied to PR's that are ready for QA, especially when additional review is pending.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Line goes against our challenge document in skyline project

3 participants

@sagivab @jdwilkin4 @Sboonny