Github => GitHub#462
Closed
ahstro wants to merge 1 commit intofreeCodeCamp:masterfrom
ahstro:github-stylization
Closed
Github => GitHub#462ahstro wants to merge 1 commit intofreeCodeCamp:masterfrom ahstro:github-stylization
ahstro wants to merge 1 commit intofreeCodeCamp:masterfrom
ahstro:github-stylization
Conversation
Contributor
|
👍 Good catch. LGTM. |
Contributor
|
Agreed, great catch. One thing, please submit against the staging branch, we do not accept pull requests against the master branch. |
Member
Author
|
@terakilobyte Will do, sorry if I missed that instructed somewhere. |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Just a minor thing that always bother me.
As far as I know, this shouldn't break anything, but please check the .jade files as I'm not very familiar with how they work.