Skip to content

fix(client): typo in APIs and Microservices Projects intro#42140

Merged
raisedadead merged 3 commits intofreeCodeCamp:mainfrom
heysujal:main
May 16, 2021
Merged

fix(client): typo in APIs and Microservices Projects intro#42140
raisedadead merged 3 commits intofreeCodeCamp:mainfrom
heysujal:main

Conversation

@heysujal
Copy link
Contributor

@heysujal heysujal commented May 14, 2021

Checklist:

  • I have read freeCodeCamp's contribution guidelines.
  • My pull request has a descriptive title (not a vague title like Update index.md)
  • My pull request targets the main branch of freeCodeCamp.
  • All the files I changed are in the same world language, for example: only English changes, or only Chinese changes, etc.

I fixed the typo in APIs and Microservices Projects introduction

fcc

Error can be found at line 315 of client/i18n/locales/english/intro.json and line 336 of client/i18n/locales/espanol/intro.json

@heysujal heysujal requested a review from a team May 14, 2021 23:22
@gitpod-io
Copy link

gitpod-io bot commented May 14, 2021

@github-actions
Copy link
Contributor

github-actions bot commented May 14, 2021

Thanks for your pull-request.

We are no longer accepting changes to the non-English versions of files in parts of this codebase. This pull-request seems to change some of those. Please visit our contributing guidelines to learn more about translating freeCodeCamp's resources.

As always, we value all of your contributions.

Happy contributing!

Note: This message was automatically generated by a bot. If you feel this message is in error or would like help resolving it, feel free to reach us in our contributor chat.

@github-actions github-actions bot added platform: learn UI side of the client application that needs familiarity with React, Gatsby etc. scope: i18n language translation/internationalization. Often combined with language type label labels May 14, 2021
@gikf
Copy link
Member

gikf commented May 15, 2021

Hey @heysujal

could you revert changes made to the Espanol locale? Non-English files should not be changed directly, if needed, they will be updated using the translating workflow.

@gikf gikf added the status: waiting update Is awaiting update, after feedback or request for changes label May 15, 2021
@heysujal
Copy link
Contributor Author

heysujal commented May 15, 2021 •
edited
Loading

@gikf I reverted my change by making another commit.

@gikf gikf added status: waiting review To be applied to PR's that are ready for QA, especially when additional review is pending. and removed status: waiting update Is awaiting update, after feedback or request for changes labels May 15, 2021
gikf
gikf approved these changes May 15, 2021
View reviewed changes
Copy link
Member

@gikf gikf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍

@raisedadead
Copy link
Member

raisedadead commented May 16, 2021

✨ ✨ AWESOME! LGTM. ✨ ✨

Thanks, @heysujal, for this pull request and for contributing to the code-base for the first time.

We will be looking forward to more contributions in future.

Cheers and happy contributing!

@raisedadead raisedadead changed the title Fixed typo in APIs and Microservices Projects intro fix(client): typo in APIs and Microservices Projects intro May 16, 2021
@raisedadead raisedadead merged commit 8ba3b8c into freeCodeCamp:main May 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@raisedadead raisedadead raisedadead approved these changes

@gikf gikf gikf approved these changes

Assignees

No one assigned

Labels

platform: learn UI side of the client application that needs familiarity with React, Gatsby etc. scope: i18n language translation/internationalization. Often combined with language type label status: waiting review To be applied to PR's that are ready for QA, especially when additional review is pending.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@heysujal @gikf @raisedadead