new Pair Code feature PR to ux-improvements instead of master#322
new Pair Code feature PR to ux-improvements instead of master#322aldraco wants to merge 69 commits intofreeCodeCamp:ux-improvementsfrom
Conversation
Fixed indenting
|
Please let me know if the formatting is still off. I changed my settings and it looks okay on my end, but uploaded here looks like it's spacing funny again. |
|
The pairWith.jade you removed the iframe for gitter. If you keep that iframe there you can replace the gitter url with https://freecode.slack.com/messages/@!{otherPersonsSlackHandleHere} and it will put them in a direct chat with that person. |
|
Sadly not. slack has prohibited cross-site scripting. |
|
Just confirmed. We can however use that generated url as a link with a target="_blank" to open a new window. This will provide a simple QoL feature. |
|
Feedback: This looks mostly GREAT! A few pointed areas of constructive criticism and some requests. RequestI know I had you guys put this against ux-improvements but please re-submit against master. The reason for the past switch and the new switch is to get you guys on the latest code we are working on. Myself and Quincy have gone ahead and resolved the merge conflicts that were present against the most recent version of ux-improvements. Feedback
|
took out gitter and adding slack integration.
We are not able to embed a slack chat due to cross scripting restrictions from slack.
We could add the bot integration, but for now the user is able to add details and other users can see their slack handle to find them.