Skip to content

updated the tests to avoid confusion issue-15012#17571

Closed
prateek3255 wants to merge 2 commits intofreeCodeCamp:stagingfrom
prateek3255:prateek3255-fix-15012
Closed

updated the tests to avoid confusion issue-15012#17571
prateek3255 wants to merge 2 commits intofreeCodeCamp:stagingfrom
prateek3255:prateek3255-fix-15012

Conversation

@prateek3255
Copy link
Copy Markdown
Contributor

@prateek3255 prateek3255 commented Jun 13, 2018 •
edited
Loading

Pre-Submission Checklist

  • Your pull request targets the staging branch of freeCodeCamp.
  • Branch starts with either fix/, feature/, or translate/ (e.g. fix/signin-issue)
  • You have only one commit (if not, squash them into one commit).
  • All new and existing tests pass the command npm test. Use git commit --amend to amend any fixes.

Type of Change

  • Small bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds new functionality)
  • Breaking change (fix or feature that would change existing functionality)
  • Add new translation (feature adding new translations)

Checklist:

  • Tested changes locally.
  • Addressed currently open issue (replace XXXXX with an issue no in next line)

Closes #15012

Description

I have updated the tests so that the tests work even if there is space before or after : and space after "" or any other value.

@camperbot
Copy link
Copy Markdown
Contributor

camperbot commented Jun 13, 2018

@prateek3255 thanks for the PR.
Your branch name should start with one of bug/, chore/, fix/, feat/, feature/, translate/ prefixes. Name your branches correctly next time, please.
Please review our Guidelines for Contributing, thank you!

@prateek3255
Copy link
Copy Markdown
Contributor Author

prateek3255 commented Jun 13, 2018

I have updated the tests for the issue #15012 so that the test work even if there is space before or after : and space after "" or any other value.

@prateek3255 prateek3255 mentioned this pull request Jun 14, 2018
Closed
@raisedadead raisedadead added status: waiting review To be applied to PR's that are ready for QA, especially when additional review is pending. scope: curriculum Lessons, Challenges, Projects and other Curricular Content in curriculum directory. labels Jun 15, 2018
@prateek3255
Copy link
Copy Markdown
Contributor Author

prateek3255 commented Jun 20, 2018

@ahmadabdolsaheb can you please review my PR because of it been 5 days since it has been marked ready for QA and there is no progress yet.

@raisedadead raisedadead added status: blocked In a transient & temporary hold. and removed status: waiting review To be applied to PR's that are ready for QA, especially when additional review is pending. labels Jun 21, 2018
@camperbot
Copy link
Copy Markdown
Contributor

camperbot commented Jun 21, 2018

@scissorsneedfoodtoo updated the pull request.

@scissorsneedfoodtoo
Copy link
Copy Markdown
Contributor

scissorsneedfoodtoo commented Jun 21, 2018 •
edited
Loading

@prateek3255, thank you for submitting a PR to fix this issue. Sorry for the delay. We're currently in the process of moving all updates to the curriculum over to a separate repository, so your PR is blocked for now.

I checked it out and everything LGTM! Just made one small change to allow for possible spaces between the parentheses and -45deg.

@raisedadead, myself, or any other members will merge things are ready with the new repo.

@raisedadead
Copy link
Copy Markdown
Member

raisedadead commented Jun 25, 2018

Hi @prateek3255

Thanks a lot for this pull request. We sincerely appreciate the time and efforts put into this.

However can you please make the same changes once again on the https://github.com/freeCodeCamp/curriculum repository?

I would like to apologise for the inconvenience, but at this point it has become very difficult to carry over commits into the other repo, to which we have moved over the entire curriculum package.

Thanks once again.

Please reach out to us in the Contributors Chat room for any assistance.

Happy contributing!

@raisedadead raisedadead removed the status: blocked In a transient & temporary hold. label Jun 25, 2018
@prateek3255
Copy link
Copy Markdown
Contributor Author

prateek3255 commented Jun 26, 2018

Yeah sure, I would make those changes in https://github.com/freeCodeCamp/curriculum repository as soon as I can.

@prateek3255 prateek3255 mentioned this pull request Jun 26, 2018
Merged
10 tasks
@prateek3255
Copy link
Copy Markdown
Contributor Author

prateek3255 commented Jun 26, 2018

@raisedadead I have submitted #57 pull request with the same changes in the https://github.com/freeCodeCamp/curriculum repository.

@raisedadead
Copy link
Copy Markdown
Member

raisedadead commented Jun 26, 2018

@prateek3255 Thanks a lot for the updates.

@prateek3255
Copy link
Copy Markdown
Contributor Author

prateek3255 commented Jun 26, 2018

@raisedadead there is one more problem, the Travis CI tests are failing on that repo even when I made the exact same changes in my commit.

@raisedadead
Copy link
Copy Markdown
Member

raisedadead commented Jun 26, 2018

OK no worries, I'll comment there after I am able to take a look.

@prateek3255
Copy link
Copy Markdown
Contributor Author

prateek3255 commented Jun 27, 2018

@raisedadead I have fixed the Travis CI test failing issue ( I just had to change my commit message to fix(challenge): ... ) thanks to the Contributors Chat room.
Now I think that it is ready to be merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

scope: curriculum Lessons, Challenges, Projects and other Curricular Content in curriculum directory.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@prateek3255 @camperbot @scissorsneedfoodtoo @raisedadead