fix(challenges): Fix octal escape sequence error#16385
fix(challenges): Fix octal escape sequence error#16385scissorsneedfoodtoo wants to merge 5 commits intofreeCodeCamp:stagingfrom
Conversation
Another user is having a problem with their pull request because the Travis Cl build keeps failing. Each time the Travis Cl build throws an error about an octal literal escape sequence not being allowed in strict mode, and it seems to happen with the Create a Priority Queue Class challenge. BREAKING CHANGE: None
|
@AungMyoKyaw will you be interested in QA for this? |
|
@raisedadead, Sorry! I should have thought of this sooner. If @AungMyoKyaw can add the code here to the pull request that keeps failing the build, then we don't need to coordinate between two separate pull requests to solve one issue. |
|
Hi @scissorsneedfoodtoo scissorsneedfoodtoo#1 That will update this PR of yours. |
|
Sure thing! I'll do that now. |
…eeCodeCamp into AungMyoKyaw-feat/eluer-prob-4
Another user is having a problem with their pull request because the Travis Cl build keeps failing. Each time the Travis Cl build throws an error about an octal literal escape sequence not being allowed in strict mode, and it seems to happen with the Create a Priority Queue Class challenge. BREAKING CHANGE: None feat(euler-problem): Add tests and solution for Problem 4: Largest palindrome product
|
@scissorsneedfoodtoo updated the pull request. |
|
Turns out I was way off base. There was no problem with the "Create a Priority Queue Class" challenge, and it was either the tests, solution, or both from Euler "Problem 4: Largest palindrome product" causing the issues. |
|
Yikes, we have some unwanted commits in there. I am sorry I should have been clearer for you in the instruction earlier, that you should have had to only hit the 'Squash and merge' button on the PR that I created. Never mind, I'll take a look asap and fix this. Sorry once again. |
|
@raisedadead, I'm sorry about that! I should have pressed the button, but ended up running the autogen commands instead and played with the files trying to solve the issue. Ended up messing up the commit pretty badly! |
|
No worries, it git and hence fixable..! BTW just to confirm we want the commit you have for this PR originally and the commit from @AungMyoKyaw 's original PR. i.e: Correct ? |
|
Actually, maybe the best thing to do is close this. Turns out the problem has to do with the solution in @AungMyoKyaw's original PR. If we remove the solution there, |
|
Okay, then lets proceed with that discussion there and close this |
|
Okay! Thanks again for all your help. Sorry about the trouble. |
|
No worries thanks for all the effort in this! |
Pre-Submission Checklist
stagingbranch of freeCodeCamp.fix/,feature/, ortranslate/(e.g.fix/signin-issue)npm test. Usegit commit --amendto amend any fixes.Type of Change
Checklist:
Closes #16396
Description
Another user is having a problem with their pull request because the
Travis Cl build keeps failing. Each time the Travis Cl build throws an
error about an octal literal escape sequence not being allowed in strict
mode, and it seems to happen with the Create a Priority Queue Class
challenge.
BREAKING CHANGE: None