Skip to content

replace Hyperdev references with Gomix#13166

Merged
raisedadead merged 1 commit intofreeCodeCamp:stagingfrom
dhcodes:fix/change-hyperdev-to-gomix
Feb 8, 2017
Merged

replace Hyperdev references with Gomix#13166
raisedadead merged 1 commit intofreeCodeCamp:stagingfrom
dhcodes:fix/change-hyperdev-to-gomix

Conversation

@dhcodes
Copy link
Copy Markdown
Contributor

@dhcodes dhcodes commented Feb 5, 2017

Pre-Submission Checklist

  • Your pull request targets the staging branch of freeCodeCamp.
  • Branch starts with either fix/, feature/, or translate/ (e.g. fix/signin-issue)
  • You have only one commit (if not, squash them into one commit).
  • All new and existing tests pass the command npm test. Use git commit --amend to amend any fixes.

Type of Change

  • Small bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds new functionality)
  • Breaking change (fix or feature that would change existing functionality)
  • Add new translation (feature adding new translations)

Checklist:

Description

Changed all instances of Hyperdev to Gomix.

@BerkeleyTrue BerkeleyTrue added the status: waiting review To be applied to PR's that are ready for QA, especially when additional review is pending. label Feb 5, 2017
@Greenheart Greenheart self-requested a review February 5, 2017 20:22
Greenheart
Greenheart reviewed Feb 5, 2017
View reviewed changes
Copy link
Copy Markdown
Member

@Greenheart Greenheart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dhcodes This looks good!

I'm just unsure if we should change these instances of "hyperdev" too.
@BerkeleyTrue would probably be the right person to answer that.

@raisedadead
Copy link
Copy Markdown
Member

raisedadead commented Feb 5, 2017

✨ ✨ LGTM. ✨ ✨

Thanks @dhcodes and yes, we need to update the file pointed above by @Greenheart ! Good catch.

@Greenheart
Copy link
Copy Markdown
Member

Greenheart commented Feb 5, 2017 •
edited
Loading

@raisedadead That function seems to be some kind of protection against malicious code. Maybe we should change it to take both hyperdev and gomix into account?

Or can we be sure that no URLs will use hyperdev?

@BerkeleyTrue
Copy link
Copy Markdown
Contributor

BerkeleyTrue commented Feb 6, 2017 •
edited
Loading

That function seems to be some kind of protection against malicious code. Maybe we should change it to take both hyperdev and gomix into account?

@Greenheart Actually we have removed hyperdev from our connect src csp so code with ajax requests to hyperdev will no longer run. We will need to change that transformer to check for gomix domains instead of hyperev. Also, those error descriptions should be a little more informative.

That being said, I think that should come in a separate PR.

@raisedadead raisedadead mentioned this pull request Feb 6, 2017
Merged
7 tasks
@raisedadead raisedadead merged commit 6562ba3 into freeCodeCamp:staging Feb 8, 2017
@raisedadead raisedadead removed the status: waiting review To be applied to PR's that are ready for QA, especially when additional review is pending. label Feb 8, 2017
This was referenced Sep 12, 2021
Open
Open
Open
Open
Open
Open
Open
@simha95 simha95 mentioned this pull request May 14, 2022
Open
@fcsouza fcsouza mentioned this pull request May 14, 2022
Open
@bobby-lin bobby-lin mentioned this pull request May 14, 2022
Open
@snyk-bot snyk-bot mentioned this pull request Sep 29, 2022
Open
@fcsouza fcsouza mentioned this pull request Oct 7, 2022
Open
@MaxMood96 MaxMood96 mentioned this pull request Dec 3, 2023
Open
@MaxMood96 MaxMood96 mentioned this pull request May 13, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@Greenheart Greenheart Greenheart left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@dhcodes @raisedadead @Greenheart @BerkeleyTrue