Skip to content

Fix sequencing issues in Basic CSS section#12809

Merged
dhcodes merged 1 commit intofreeCodeCamp:stagingfrom
HKuz:fix/CSSsequencing
Jan 27, 2017
Merged

Fix sequencing issues in Basic CSS section#12809
dhcodes merged 1 commit intofreeCodeCamp:stagingfrom
HKuz:fix/CSSsequencing

Conversation

@HKuz
Copy link
Copy Markdown
Member

@HKuz HKuz commented Jan 24, 2017

Pre-Submission Checklist

  • Your pull request targets the staging branch of freeCodeCamp.
  • Branch starts with either fix/, feature/, or translate/ (e.g. fix/signin-issue)
  • You have only one commit (if not, squash them into one commit).
  • All new and existing tests pass the command npm test. Use git commit --amend to amend any fixes.

Type of Change

  • Small bug fix (non-breaking change which fixes an issue)

Checklist:

Description

  • After the HTML and CSS sections were split, the CatPhotoApp challenges didn't flow properly. This PR follows off the changes made in PR Remove CSS from HTML section #12752 - it takes where the HTML for the CatPhotoApp leaves off and carries it through the applicable challenges in the Basic CSS section.
  • Only one challenge's instructions changed slightly, I used Google Translate as a best efforts attempt to modify the translations
  • Applies the <hr> to delineate instructions for all challenges

@dhcodes dhcodes self-requested a review January 25, 2017 17:16
dhcodes
dhcodes suggested changes Jan 25, 2017
View reviewed changes
Copy link
Copy Markdown
Contributor

@dhcodes dhcodes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few changes that I think will help campers and prevent later questions/issues.

seed/challenges/01-responsive-web-design/basic-css.json Outdated

This comment was marked as off-topic.

Sign in to view

seed/challenges/01-responsive-web-design/basic-css.json Outdated

This comment was marked as off-topic.

Sign in to view

seed/challenges/01-responsive-web-design/basic-css.json Outdated

This comment was marked as off-topic.

Sign in to view

seed/challenges/01-responsive-web-design/basic-css.json Outdated

This comment was marked as off-topic.

Sign in to view

This comment was marked as off-topic.

Sign in to view

@dhcodes dhcodes added the status: blocked In a transient & temporary hold. label Jan 25, 2017
@HKuz
Copy link
Copy Markdown
Member Author

HKuz commented Jan 25, 2017

Thanks @dhcodes - all good points. Working on these now!

@HKuz
Copy link
Copy Markdown
Member Author

HKuz commented Jan 25, 2017

@dhcodes - changes should be in place here. I put the language about styling an id in the Use and ID Attribute to Style an Element challenge. Your text fix well right after the existing first sentence, but let me know if you prefer it elsewhere. Thanks! 👍

dhcodes
dhcodes suggested changes Jan 26, 2017
View reviewed changes
seed/challenges/01-responsive-web-design/basic-css.json Outdated

This comment was marked as off-topic.

Sign in to view

This comment was marked as off-topic.

Sign in to view

This comment was marked as off-topic.

Sign in to view

seed/challenges/01-responsive-web-design/basic-css.json Outdated

This comment was marked as off-topic.

Sign in to view

@dhcodes
Copy link
Copy Markdown
Contributor

dhcodes commented Jan 26, 2017

@HKuz Sorry I have a few more requests 😞

@HKuz
Copy link
Copy Markdown
Member Author

HKuz commented Jan 26, 2017

No worries, I've got to earn that 🌮 to get this in good shape!

@HKuz
Copy link
Copy Markdown
Member Author

HKuz commented Jan 27, 2017

@dhcodes latest changes, let me know if you catch anything else 👍

@dhcodes
Copy link
Copy Markdown
Contributor

dhcodes commented Jan 27, 2017

Thanks @HKuz. I think this flows much better. Thanks for undertaking this! 🦅 🌮 💯

Tested locally and LGTM

@dhcodes dhcodes merged commit c5a7a47 into freeCodeCamp:staging Jan 27, 2017
@BerkeleyTrue BerkeleyTrue removed the status: blocked In a transient & temporary hold. label Jan 27, 2017
@HKuz
Copy link
Copy Markdown
Member Author

HKuz commented Jan 27, 2017

I scored the 🦅 too, nice! Thanks for QA'ing this, @dhcodes 🥇

@HKuz HKuz deleted the fix/CSSsequencing branch January 27, 2017 19:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@dhcodes dhcodes dhcodes approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@HKuz @dhcodes @BerkeleyTrue