Skip to content

Allow bracket notation and search for dot notation#12334

Merged
dhcodes merged 1 commit intofreeCodeCamp:stagingfrom
Manish-Giri:fix/add-bracket-notation
Jan 3, 2017
Merged

Allow bracket notation and search for dot notation#12334
dhcodes merged 1 commit intofreeCodeCamp:stagingfrom
Manish-Giri:fix/add-bracket-notation

Conversation

@Manish-Giri
Copy link
Copy Markdown
Contributor

Pre-Submission Checklist

  • Your pull request targets the staging branch of FreeCodeCamp.
  • Branch starts with either fix/, feature/, or translate/ (e.g. fix/signin-issue)
  • You have only one commit (if not, squash them into one commit).
  • All new and existing tests pass the command npm test. Use git commit --amend to amend any fixes.

Type of Change

  • Small bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds new functionality)
  • Breaking change (fix or feature that would change existing functionality)
  • Add new translation (feature adding new translations)

Checklist:

Description

Modified test to allow the use of bracket notation, along with dot notation, to pass the challenge. Also, escaped the . to search strictly for usage of dot notation.

Verified the code in my local instance with val.imageLink and val["imageLink"].

closes #12031

@BerkeleyTrue BerkeleyTrue added the status: waiting review To be applied to PR's that are ready for QA, especially when additional review is pending. label Jan 3, 2017
@dhcodes
Copy link
Copy Markdown
Contributor

dhcodes commented Jan 3, 2017

Tested locally and LGTM. Thanks @Manish-Giri 🌮 🎉 💯

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants