Skip to content

Update instructions for Stand in Line Challenge#12068

Merged
raisedadead merged 1 commit intofreeCodeCamp:stagingfrom
DarrenfJ:update_instructions/Stand_in_Line_Challenge
Dec 16, 2016
Merged

Update instructions for Stand in Line Challenge#12068
raisedadead merged 1 commit intofreeCodeCamp:stagingfrom
DarrenfJ:update_instructions/Stand_in_Line_Challenge

Conversation

@DarrenfJ
Copy link
Copy Markdown
Contributor

@DarrenfJ DarrenfJ commented Dec 16, 2016 •
edited by raisedadead
Loading

Pre-Submission Checklist

  • Your pull request targets the staging branch of FreeCodeCamp.
  • Branch starts with either fix/, feature/, or translate/ (e.g. fix/signin-issue)
  • You have only one commit (if not, squash them into one commit).
  • All new and existing tests pass the command npm test. Use git commit --amend to amend any fixes.

Type of Change

  • Small bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds new functionality)
  • Breaking change (fix or feature that would change existing functionality)
  • Add new translation (feature adding new translations)

Checklist:

Description

Update instructions for Stand in Line Challenge

Change instructions from 1 line to 3 (new paragraphs)
line 2747

@camperbot
Copy link
Copy Markdown
Contributor

camperbot commented Dec 16, 2016

@DarrenfJ thanks for the PR.
Your branch name should start with one of fix/, feature/, translate/ prefixes. Name, your branches correctly next time, please.
Please, review our Guidelines for Contributing, thank you!.

@BerkeleyTrue BerkeleyTrue added the status: waiting review To be applied to PR's that are ready for QA, especially when additional review is pending. label Dec 16, 2016
@DarrenfJ
Copy link
Copy Markdown
Contributor Author

DarrenfJ commented Dec 16, 2016

Ah! I get it! I thought when you said you wanted to branch to be fix/short-fix-description you wanted the fix described in the first part but you 'literally' just want the word 'fix/'.

Ha! d'oh... Apologies guys. Next time.

D

@raisedadead
Copy link
Copy Markdown
Member

raisedadead commented Dec 16, 2016

Thanks for the pull request @DarrenfJ !

Yes, except for the branch name the changes look neat. Just have a look at our contributing guidelines.

Most importantly, please test your code locally and run the npm test on a command line. This is very important to know if anything is not broken by your change.

Happy fixing.

raisedadead
raisedadead approved these changes Dec 16, 2016
View reviewed changes
Copy link
Copy Markdown
Member

@raisedadead raisedadead left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM

@raisedadead
Copy link
Copy Markdown
Member

raisedadead commented Dec 16, 2016 •
edited
Loading

Tested locally.

✨ ✨ LGTM. ✨ ✨

Thanks and congrats @DarrenfJ on your first contrinution to Free Code Camp!

@raisedadead raisedadead merged commit 0e984fe into freeCodeCamp:staging Dec 16, 2016
@raisedadead raisedadead removed the status: waiting review To be applied to PR's that are ready for QA, especially when additional review is pending. label Dec 16, 2016
@DarrenfJ
Copy link
Copy Markdown
Contributor Author

DarrenfJ commented Dec 16, 2016

Thanks guys! Looking forward to more.

@DarrenfJ DarrenfJ deleted the update_instructions/Stand_in_Line_Challenge branch December 16, 2016 15:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@raisedadead raisedadead raisedadead approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@DarrenfJ @camperbot @raisedadead @BerkeleyTrue