Skip to content

Center Testimonial Text#12025

Merged
erictleung merged 1 commit intofreeCodeCamp:stagingfrom
hudsontaylor:patch-1
Dec 15, 2016
Merged

Center Testimonial Text#12025
erictleung merged 1 commit intofreeCodeCamp:stagingfrom
hudsontaylor:patch-1

Conversation

@hudsontaylor
Copy link
Copy Markdown
Contributor

@hudsontaylor hudsontaylor commented Dec 13, 2016 •
edited
Loading

Pre-Submission Checklist

  • Your pull request targets the staging branch of FreeCodeCamp.
  • Branch starts with either fix/, feature/, or translate/ (e.g. fix/signin-issue)
  • You have only one commit (if not, squash them into one commit).
  • All new and existing tests pass the command npm test. Use git commit --amend to amend any fixes.

Type of Change

  • Small bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds new functionality)
  • Breaking change (fix or feature that would change existing functionality)
  • Add new translation (feature adding new translations)

Checklist:

Description

This gets rid of the odd white spaces in the testimonials section by just centering the text instead of justifying it.

@camperbot
Copy link
Copy Markdown
Contributor

camperbot commented Dec 13, 2016

@hudsontaylor thanks for the PR.
Your branch name should start with one of fix/, feature/, translate/ prefixes. Name, your branches correctly next time, please.
Please, review our Guidelines for Contributing, thank you!.

@BerkeleyTrue BerkeleyTrue added the status: waiting review To be applied to PR's that are ready for QA, especially when additional review is pending. label Dec 13, 2016
@raisedadead
Copy link
Copy Markdown
Member

raisedadead commented Dec 13, 2016

@hudsontaylor thanks a lot for the pull request. ✨

We are good to go. Kindly fill in the checklist and amend your commit to removing the issue no. from the commit text.

This gets rid of the odd white spaces in the testimonials section by just centering the text instead > of justifying it.

For any assistance hit us up on the Contributors Chat room.

Happy fixing!

@raisedadead raisedadead self-requested a review December 13, 2016 17:52
raisedadead
raisedadead requested changes Dec 13, 2016
View reviewed changes
Copy link
Copy Markdown
Member

@raisedadead raisedadead left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM. Just update the commit message and fill in the checklist.

@hudsontaylor @raisedadead
Center Testimonial Text
80eae43 
This gets rid of the odd white spaces in the testimonials section by just centering the text instead of justifying it.
@raisedadead
Copy link
Copy Markdown
Member

raisedadead commented Dec 13, 2016

Can someone merge, since I fixed a commit message via my own commit for the OP. Thanks.

@erictleung
Copy link
Copy Markdown
Member

erictleung commented Dec 15, 2016

@hudsontaylor LGTM! 👍 Thanks for your contribution to FreeCodeCamp! ✨ 🎉 ✨

@erictleung erictleung merged commit 6fd5f96 into freeCodeCamp:staging Dec 15, 2016
@erictleung erictleung removed the status: waiting review To be applied to PR's that are ready for QA, especially when additional review is pending. label Dec 15, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@raisedadead raisedadead raisedadead approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@hudsontaylor @camperbot @raisedadead @erictleung @BerkeleyTrue