Skip to content

Update Redirect when cancelling to remove account#11923

Merged
dhcodes merged 1 commit intofreeCodeCamp:stagingfrom
ajain17:fix/updateRedirect
Dec 6, 2016
Merged

Update Redirect when cancelling to remove account#11923
dhcodes merged 1 commit intofreeCodeCamp:stagingfrom
ajain17:fix/updateRedirect

Conversation

@ajain17
Copy link
Copy Markdown

@ajain17 ajain17 commented Dec 5, 2016 •
edited
Loading

Pre-Submission Checklist

  • Your pull request targets the staging branch of FreeCodeCamp.
  • Branch starts with either fix/, feature/, or translate/ (e.g. fix/signin-issue)
  • You have only one commit (if not, squash them into one commit).
  • All new and existing tests pass the command npm test. Use git commit --amend to amend any fixes.

Type of Change

  • Small bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds new functionality)
  • Breaking change (fix or feature that would change existing functionality)
  • Add new translation (feature adding new translations)

Checklist:

  • Tested changes locally.
  • Closes currently open issue (replace XXXX with an issue no): Closes 11922

Description

@BerkeleyTrue BerkeleyTrue added the status: waiting review To be applied to PR's that are ready for QA, especially when additional review is pending. label Dec 5, 2016
@ajain17 ajain17 mentioned this pull request Dec 5, 2016
Closed
dhcodes
dhcodes suggested changes Dec 5, 2016
View reviewed changes
Copy link
Copy Markdown
Contributor

@dhcodes dhcodes left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also please change the "Nevermind, I don't want to delete..." button to /settings in line 17

@dhcodes dhcodes added status: blocked In a transient & temporary hold. and removed status: waiting review To be applied to PR's that are ready for QA, especially when additional review is pending. labels Dec 5, 2016
@ajain17 ajain17 force-pushed the fix/updateRedirect branch from 5ebd03d to c193c08 Compare December 6, 2016 00:29
@camperbot
Copy link
Copy Markdown
Contributor

camperbot commented Dec 6, 2016

@ajain17 updated the pull request.

@dhcodes
Copy link
Copy Markdown
Contributor

dhcodes commented Dec 6, 2016

Tested, works. LGTM. Thanks for contributing 🌮 🎉 ✨

@dhcodes dhcodes merged commit ac4551a into freeCodeCamp:staging Dec 6, 2016
@BerkeleyTrue BerkeleyTrue removed the status: blocked In a transient & temporary hold. label Dec 6, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@dhcodes dhcodes dhcodes approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@ajain17 @camperbot @dhcodes @BerkeleyTrue