Skip to content

Reorder projects and challenges from newest to oldest#11904

Merged
raisedadead merged 1 commit intofreeCodeCamp:stagingfrom
mtaner:fix/project-ordering
Dec 12, 2016
Merged

Reorder projects and challenges from newest to oldest#11904
raisedadead merged 1 commit intofreeCodeCamp:stagingfrom
mtaner:fix/project-ordering

Conversation

@mtaner
Copy link
Copy Markdown
Contributor

@mtaner mtaner commented Dec 3, 2016 •
edited by Bouncey
Loading

Pre-Submission Checklist

  • Your pull request targets the staging branch of FreeCodeCamp.
  • Branch starts with either fix/, feature/, or translate/ (e.g. fix/signin-issue)
  • You have only one commit (if not, squash them into one commit).
  • All new and existing tests pass the command npm test. Use git commit --amend to amend any fixes.

Type of Change

  • Small bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds new functionality)
  • Breaking change (fix or feature that would change existing functionality)
  • Add new translation (feature adding new translations)

Checklist:

Description

Reverse the order of the projects and challenges displayed.

@BerkeleyTrue BerkeleyTrue added the status: waiting review To be applied to PR's that are ready for QA, especially when additional review is pending. label Dec 3, 2016
@Bouncey
Copy link
Copy Markdown
Member

Bouncey commented Dec 4, 2016

@mtaner thanks for the PR.

I am putting this on hold for now whilst we wait for opinions

@Bouncey Bouncey added the status: blocked In a transient & temporary hold. label Dec 4, 2016
@ooade
Copy link
Copy Markdown

ooade commented Dec 4, 2016

LGTM! 👍

@ghost
Copy link
Copy Markdown

ghost commented Dec 4, 2016

@QuincyLarson, tagging for approval.

@valmassoi valmassoi mentioned this pull request Dec 5, 2016
Closed
@systimotic systimotic removed the status: blocked In a transient & temporary hold. label Dec 5, 2016
@ygt-abooth
Copy link
Copy Markdown

ygt-abooth commented Dec 5, 2016

LGTM 😄

@raisedadead
Copy link
Copy Markdown
Member

raisedadead commented Dec 12, 2016

Tested, and LGTM. @mtaner thanks and sorry about the delay in QA! 😄

/cc @QuincyLarson I am merging. Please let me know for changes if any.

@raisedadead raisedadead merged commit 42f21cc into freeCodeCamp:staging Dec 12, 2016
@raisedadead raisedadead removed the status: waiting review To be applied to PR's that are ready for QA, especially when additional review is pending. label Dec 12, 2016
@QuincyLarson
Copy link
Copy Markdown
Contributor

QuincyLarson commented Dec 13, 2016

Awesome - thanks for submitting this PR, @mtaner and thanks to @ygt-abooth and @raisedadead for QA'ing it. Excited to get this live when we ship staging 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

@mtaner @Bouncey @ooade @ygt-abooth @raisedadead @QuincyLarson @BerkeleyTrue @systimotic