Skip to content

Remove reset/delete account progress animations and change color/increase size of buttons #11881

Merged
1 commit merged intofreeCodeCamp:stagingfrom
johnnyqbui:fix/reset-animations
Dec 4, 2016
Merged

Remove reset/delete account progress animations and change color/increase size of buttons #11881
1 commit merged intofreeCodeCamp:stagingfrom
johnnyqbui:fix/reset-animations

Conversation

@johnnyqbui
Copy link
Copy Markdown
Contributor

@johnnyqbui johnnyqbui commented Dec 1, 2016 •
edited
Loading

Pre-Submission Checklist

  • Your pull request targets the staging branch of FreeCodeCamp.
  • Branch starts with either fix/, feature/, or translate/ (e.g. fix/signin-issue)
  • You have only one commit (if not, squash them into one commit).
  • All new and existing tests pass the command npm test. Use git commit --amend to amend any fixes.

Type of Change

  • Small bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds new functionality)
  • Breaking change (fix or feature that would change existing functionality)
  • Add new translation (feature adding new translations)

Checklist:

Description

Remove reset progress and delete account animations, change color of success button to green, and increase button size tap targets

@BerkeleyTrue BerkeleyTrue added the status: waiting review To be applied to PR's that are ready for QA, especially when additional review is pending. label Dec 1, 2016
@ghost ghost self-assigned this Dec 1, 2016
ghost
ghost suggested changes Dec 1, 2016
View reviewed changes
client/less/main.less Outdated

This comment was marked as off-topic.

Sign in to view

This comment was marked as off-topic.

Sign in to view

@ghost ghost added status: blocked In a transient & temporary hold. and removed status: waiting review To be applied to PR's that are ready for QA, especially when additional review is pending. labels Dec 1, 2016
@johnnyqbui johnnyqbui force-pushed the fix/reset-animations branch from e335bd9 to 7316960 Compare December 1, 2016 18:05
@camperbot
Copy link
Copy Markdown
Contributor

camperbot commented Dec 1, 2016

@johnnyqbui updated the pull request.

@johnnyqbui johnnyqbui force-pushed the fix/reset-animations branch from 3d59b81 to baf225a Compare December 1, 2016 19:56
@camperbot
Copy link
Copy Markdown
Contributor

camperbot commented Dec 1, 2016

@johnnyqbui updated the pull request.

@ghost ghost added status: waiting review To be applied to PR's that are ready for QA, especially when additional review is pending. and removed status: blocked In a transient & temporary hold. labels Dec 2, 2016
@dhcodes
Copy link
Copy Markdown
Contributor

dhcodes commented Dec 3, 2016

LGTM.

@atjonathan Is the following behavior intended?
When canceling the modal for deleting the account, it goes to the about page.
When canceling the modal for resetting progress, it goes back to the settings page.

That may be outside the scope of this PR.

@ghost
Copy link
Copy Markdown

ghost commented Dec 4, 2016

@dhcodes

When canceling the modal for deleting the account, it goes to the about page.

That behavior should be changed. The other seems fine. I opened a new issue (#11922), as this PR is irrelevant.

@johnnyqbui, LGTM 👍
Thanks for contributing, loving the UI improvements 💪

@ghost ghost merged commit 1934b70 into freeCodeCamp:staging Dec 4, 2016
@ghost ghost removed the status: waiting review To be applied to PR's that are ready for QA, especially when additional review is pending. label Dec 4, 2016
This was referenced Jan 21, 2020
Open
Open
Open
Open
Open
@SC0T1ISHNiNjA SC0T1ISHNiNjA mentioned this pull request Nov 27, 2023
Open
@yuhonghong66 yuhonghong66 mentioned this pull request Nov 28, 2023
Open
@ajesse11x ajesse11x mentioned this pull request Nov 28, 2023
Open
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@johnnyqbui @camperbot @dhcodes @BerkeleyTrue