-
-
Notifications
You must be signed in to change notification settings - Fork 44.1k
new lines and spaces cause failures in tests checking element content #60690
Copy link
Copy link
Closed
Task
7 / 77 of 7 issues completed
Copy link
Labels
help wantedOpen for all. You do not need permission to work on these.Open for all. You do not need permission to work on these.scope: curriculumLessons, Challenges, Projects and other Curricular Content in curriculum directory.Lessons, Challenges, Projects and other Curricular Content in curriculum directory.
Description
this issue is only related to projects of the full stack curriculum, curriculum/challenges/english/blocks/workshop-*/ and curriculum/challenges/english/blocks/lab-*/
This is something that happens in many tests. The solution would be to always use
trimwhen we useinnerTextThe line that is making this fail is
assert.match(spanEl?.innerText, /^[⭐☆]{10}$/);, it would need to usetrim()on the first argument to passThere are many labs and workshops that have this issue that may benefit from this change
Originally posted by @ilenia-magoni in #60686
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
help wantedOpen for all. You do not need permission to work on these.Open for all. You do not need permission to work on these.scope: curriculumLessons, Challenges, Projects and other Curricular Content in curriculum directory.Lessons, Challenges, Projects and other Curricular Content in curriculum directory.