Skip to content

fix: has_returns and inherits_from helpers#509

Merged
Dario-DC merged 2 commits intofreeCodeCamp:mainfrom
Dario-DC:fix-has_returns
Oct 17, 2025
Merged

fix: has_returns and inherits_from helpers#509
Dario-DC merged 2 commits intofreeCodeCamp:mainfrom
Dario-DC:fix-has_returns

Conversation

@Dario-DC
Copy link
Copy Markdown
Contributor

@Dario-DC Dario-DC commented Oct 17, 2025

Checklist:

Closes #XXXXX

has_returns("None") was failing because it compared None with the string "None".
inherits_from("abc.ABC") was failing because it could not handle the argument.
This PR fixes both issues.

@Dario-DC Dario-DC changed the title fix: has_returns helper fix: has_returns and inherits_from helpers Oct 17, 2025
@Dario-DC Dario-DC marked this pull request as ready for review October 17, 2025 09:38
@Dario-DC Dario-DC requested a review from a team October 17, 2025 09:38
Copy link
Copy Markdown
Contributor

@ojeytonwilliams ojeytonwilliams left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@Dario-DC Dario-DC merged commit de704b2 into freeCodeCamp:main Oct 17, 2025
4 checks passed
@Dario-DC Dario-DC deleted the fix-has_returns branch October 17, 2025 10:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants