Skip to content
This repository was archived by the owner on Sep 25, 2019. It is now read-only.

(#18054) fixed code tags in description on Wrap Radio Buttons in a fieldset El…#289

Merged
scissorsneedfoodtoo merged 1 commit intofreeCodeCamp:devfrom
tannerabread:fix/applied-accessibility-description
Sep 2, 2018
Merged

(#18054) fixed code tags in description on Wrap Radio Buttons in a fieldset El…#289
scissorsneedfoodtoo merged 1 commit intofreeCodeCamp:devfrom
tannerabread:fix/applied-accessibility-description

Conversation

@tannerabread
Copy link
Copy Markdown
Contributor

@tannerabread tannerabread commented Aug 29, 2018

…ement for Better Accessibility

Description

Fixed - Wrap Radio Buttons in a fieldset Element for Better Accessibility - Description need more code tags #18054

Pre-Submission Checklist

  • Your pull request targets the dev branch.
  • Branch starts with either fix/, feature/, or translate/ (e.g. fix/challenge-tests)
  • All new and existing tests pass the command npm test.
  • Use npm run commit to generate a conventional commit message.
    Learn more here: https://conventionalcommits.org/#why-use-conventional-commits
  • The changes were done locally on your machine and NOT GitHub web interface.
    If they were done on the web interface you have ensured that you are creating conventional commit messages.

Checklist:

  • Tested changes locally.
  • Addressed currently open issue (replace XXXXX with an issue no in next line)

Closes freeCodeCamp/freeCodeCamp#18054

Fixed the code tags in the description for Wrap Radio Buttons in a fieldset Element for Better
Accessibility

ISSUES CLOSED: #18054
Copy link
Copy Markdown
Member

@Nirajn2311 Nirajn2311 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@scissorsneedfoodtoo
Copy link
Copy Markdown
Contributor

✨ ✨ ✨ Awesome! Congratulations on your first contribution to freeCodeCamp! ✨ ✨ ✨

Thank you for submitting a PR for this issue, @marijunjnja. We're all really looking forward to your next contribution. Also, thank you @Nirajn2311 for checking this out!

@tannerabread tannerabread deleted the fix/applied-accessibility-description branch September 6, 2018 15:49
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Wrap Radio Buttons in a fieldset Element for Better Accessibility - Description need more code tags

3 participants