This repository was archived by the owner on Sep 25, 2019. It is now read-only.
fix(challenges): fix description in css variable fallback challenge#264
Merged
scissorsneedfoodtoo merged 1 commit intofreeCodeCamp:devfrom Aug 26, 2018
Conversation
This commit partially resolves freeCodeCamp/freeCodeCamp#17546
Contributor
|
@joshalling, thank you for improving this challenge! It's much more clear what a fallback is and what the user is meant to do in this challenge. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
I fixed the description in this challenge to point out that the variable fallback is not used to work with browsers that don't support variables.
I also updated the instruction to call out exactly what is going on rather than explaining it as a note at the bottom.
Pre-Submission Checklist
devbranch.fix/,feature/, ortranslate/(e.g.fix/challenge-tests)npm test.npm run committo generate a conventional commit message.Learn more here: https://conventionalcommits.org/#why-use-conventional-commits
If they were done on the web interface you have ensured that you are creating conventional commit messages.
Checklist:
PARTIALLY RESOLVES: freeCodeCamp/freeCodeCamp#17546