This repository was archived by the owner on Sep 25, 2019. It is now read-only.
fix(challenges): fix flex direction row regex#261
Merged
scissorsneedfoodtoo merged 1 commit intofreeCodeCamp:devfrom Aug 24, 2018
Merged
fix(challenges): fix flex direction row regex#261scissorsneedfoodtoo merged 1 commit intofreeCodeCamp:devfrom
scissorsneedfoodtoo merged 1 commit intofreeCodeCamp:devfrom
Conversation
ISSUES CLOSED: freeCodeCamp#260
Contributor
|
@joshalling, thank you for documenting this issue and submitting this fix! Checked it out and everything LGTM 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ISSUES CLOSED: #260
Description
I improved regex for this challenge a little bit by ensuring the flex-direction declarations are in the right rules while also removing the line number restriction.
I also thought about using jQuery in the tests, but that is not possible here because row is already the default value of
flex-direction, so you could pass the challenge without doing anything.Pre-Submission Checklist
devbranch.fix/,feature/, ortranslate/(e.g.fix/challenge-tests)npm test.npm run committo generate a conventional commit message.Learn more here: https://conventionalcommits.org/#why-use-conventional-commits
If they were done on the web interface you have ensured that you are creating conventional commit messages.
Checklist:
Closes #260