fix(challenges): add note at bottom of description in d3 challenge#259
fix(challenges): add note at bottom of description in d3 challenge#259scissorsneedfoodtoo merged 1 commit intofreeCodeCamp:devfrom nischaldutt:add/note-in-description-d3-challenge
Conversation
|
@nischaldutt, thank you for taking the time to fix this issue. However, there is a small grammatical problem and an issue with some of the wording in the note you added. It seems that the circles are not really styled in later challenges, at least using the d3 style method. Instead, they just have attributes like radius and height applied to them. Would you mind updating your PR so the note reads something like the following? This is just a suggestion, so let me know what you think about the updated note and if you have any other ideas. Please take a look at this section of the Contributor's Guide for how to update your PR and amend your git commit message. Also, feel free to reach out if you need any help with the process. |
|
yes sir, I'll look forward to it. |
|
@nischaldutt, alright! Looking forward to your updated description. |
|
thank you sir, I've update the pull request as specified 😊 |
|
Yes, would you mind updating the note so it reads something like the following?
To do that, make sure you're on the right branch with Let me know if you need any help throughout the process! |
Add a short message in note at bottom of description in d3 challenge ISSUES CLOSED: #17767
|
Thanks for the valuable response :) |
|
@nischaldutt, I'm not seeing the changes here, and I think it's due to an error in the instructions I gave earlier. I'm very sorry, but I believe I told you to force push to the dev branch rather than the one you created for this PR. Let's try again: All you should have to do is make sure you're on the right branch with To get your dev branch back to normal, switch to it with Sorry again for the trouble! |
|
Makes sense, thanks for such a constructive response |
|
✨ ✨ ✨ Awesome! Congratulations on your first contribution to freeCodeCamp! ✨ ✨ ✨ Thank you for submitting a PR for this issue, @nischaldutt. We're all really looking forward to your next contribution! And sorry again for the incorrect directions earlier -- I'll be more careful next time you contribute. |
|
Thanks for guiding me throughout the process. I learned allot from it |
Add a short message in note at bottom of description in d3 challenge
ISSUES CLOSED: freeCodeCamp/freeCodeCamp#17767
Description
Pre-Submission Checklist
devbranch.fix/,feature/, ortranslate/(e.g.fix/challenge-tests)npm test.npm run committo generate a conventional commit message.Learn more here: https://conventionalcommits.org/#why-use-conventional-commits
If they were done on the web interface you have ensured that you are creating conventional commit messages.
Checklist:
Closes freeCodeCamp/freeCodeCamp#17767