fix(challenges): fixed tests to check for pre operators#222
fix(challenges): fixed tests to check for pre operators#222scissorsneedfoodtoo merged 1 commit intofreeCodeCamp:devfrom Nirajn2311:fix/update-test
Conversation
Increment and decrement a number challenge will now check for post-increment ISSUES CLOSED: #199
|
@Nirajn2311, thank you for this fix! Just tested this and everything works fine. However, @kevinsmithwebdev brings up a good point about requiring the test requiring a semicolon to pass. Would you mind updating the tests here so that's not the case? It would be good if all the tests were updated so semicolons are optional, but I know that'll be a big job. Still, we have to start somewhere, and I hope you wouldn't mind improving these tests just a little bit more. |
|
@scissorsneedfoodtoo Is it possible to update the tests for removing semicolons in another PR as some tests have been changed since this PR was made. |
|
@Nirajn2311, of course, that's not a problem at all. In that case, everything LGTM! Thanks for the heads up and for all of your hard work. |
Description
Increment and decrement a number challenge will now check for pre increment or decrement operators.
ISSUES CLOSED: #199
Pre-Submission Checklist
devbranch.fix/,feature/, ortranslate/(e.g.fix/challenge-tests)npm test.npm run committo generate a conventional commit message.Learn more here: https://conventionalcommits.org/#why-use-conventional-commits
If they were done on the web interface you have ensured that you are creating conventional commit messages.
Checklist:
Closes #XXXXX