Skip to content
This repository was archived by the owner on Sep 25, 2019. It is now read-only.

fix(challenges): update test and add solution for DS challenge#195

Merged
scissorsneedfoodtoo merged 1 commit intofreeCodeCamp:devfrom
HugoLiconV:fix/ds-bst-challenge-test
Aug 2, 2018
Merged

fix(challenges): update test and add solution for DS challenge#195
scissorsneedfoodtoo merged 1 commit intofreeCodeCamp:devfrom
HugoLiconV:fix/ds-bst-challenge-test

Conversation

@HugoLiconV
Copy link
Copy Markdown
Contributor

ISSUES CLOSED: #164

Description

I added the solutions for «Data Structures: Add a New Element to a Binary Search Tree» challenge and I also modified one test to fix issue #164

Pre-Submission Checklist

  • Your pull request targets the dev branch.
  • Branch starts with either fix/, feature/, or translate/ (e.g. fix/challenge-tests)
  • All new and existing tests pass the command npm test.
  • Use npm run commit to generate a conventional commit message.
    Learn more here: https://conventionalcommits.org/#why-use-conventional-commits
  • The changes were done locally on your machine and NOT GitHub web interface.
    If they were done on the web interface you have ensured that you are creating conventional commit messages.

Checklist:

  • Tested changes locally.
  • Addressed currently open issue (replace XXXXX with an issue no in next line)

Closes #164

@raisedadead raisedadead added the status: ready for QA To be applied to PR that are ready for QA. label Jul 30, 2018
@scissorsneedfoodtoo scissorsneedfoodtoo merged commit d1b2075 into freeCodeCamp:dev Aug 2, 2018
@scissorsneedfoodtoo
Copy link
Copy Markdown
Contributor

✨ ✨ ✨ Awesome! Congratulations on your first contribution to freeCodeCamp! ✨ ✨ ✨

Thank you for submitting a PR for this issue, @HugoLiconV. Great work here! We're all really looking forward to your next contribution.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

status: ready for QA To be applied to PR that are ready for QA.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

"Data Structures: Add a New Element to a Binary Search Tree" challenge needs more tests

3 participants