fix(challenges): fix third test for template literals#192
fix(challenges): fix third test for template literals#192scissorsneedfoodtoo merged 2 commits intofreeCodeCamp:devfrom johnkennedy9147:fix-template-literals-test-3
Conversation
replaced the overly long and complex regex which tests for use of template literals with a much simpler one that has the same effect ISSUES CLOSED: #135
|
@johnkennedy9147, thank you for continuing to improve this problem! I just found a couple of small things I'll leave as a review. |
| "A lot of things happened there.", | ||
| "Firstly, the example uses backticks (<code>`</code>), not quotes (<code>'</code> or <code>\"</code>), to wrap the string.", | ||
| "Secondly, notice that the string is multi-line, both in the code and the output. This saves inserting \n within strings.", | ||
| "Secondly, notice that the string is multi-line, both in the code and the output. This saves inserting <code>\n</code> within strings.", |
There was a problem hiding this comment.
Tested this locally and it seems like \n still needs to be escaped, whether or not it's wrapped in <code> tags. <code>\\n<code> gets it to show up locally on Learn for me.
There was a problem hiding this comment.
sorry forgot to escape the \ will fix
| "text": "Template strings were used", | ||
| "testString": | ||
| "getUserInput => assert(getUserInput('index').match(/`<li \\s*class\\s*=\\s*(\"\\s*text-warning\\s*\"|'\\s*text-warning\\s*')\\s*>\\s*\\$\\s*\\{(\\s*\\w+\\s*|\\s*\\w+\\s*\\[\\s*[\\w]+\\s*\\]\\s*)\\}\\s*<\\s*\\/li\\s*>`/g), 'Template strings were used');" | ||
| "getUserInput => assert(getUserInput('index').match(/`.*`/g), 'Template strings were used');" |
There was a problem hiding this comment.
Unfortunately it seems like the commented out section is causing this to pass. I like your simplified test much more than the last one, so how about changing the commented out section?
There was a problem hiding this comment.
I am not finding that to be the case.
unless camper manually adds backticks to the comment
and test error message
|
@johnkennedy9147, thank you for all of your hard work here. Everything LGTM! |
Description
replaced the overly long and complex regex which tests for use of template literals with a much
simpler one that has the same effect
also fixed
\nnot being displayed as it was not escaped or surrounded by code tagsISSUES CLOSED: #135
Pre-Submission Checklist
devbranch.fix/,feature/, ortranslate/(e.g.fix/challenge-tests)npm test.npm run committo generate a conventional commit message.Learn more here: https://conventionalcommits.org/#why-use-conventional-commits
If they were done on the web interface you have ensured that you are creating conventional commit messages.
Checklist:
Closes #135