fix(challenges): update test and add solution for DS challenge

HugoLiconV · scissorsneedfoodtoo · commit d1b207553bbc · 2018-08-02T17:12:40.000+09:00
ISSUES CLOSED: #164
diff --git a/challenges/08-coding-interview-prep/data-structures.json b/challenges/08-coding-interview-prep/data-structures.json
@@ -2169,15 +2169,15 @@
         },
         {
           "text": "The add method adds elements according to the binary search tree rules.",
-          "testString": "assert((function() { var test = false; if (typeof BinarySearchTree !== 'undefined') { test = new BinarySearchTree() } else { return false; }; if (typeof test.add !== 'function') { return false; }; test.add(4); test.add(1); test.add(7); test.add(87); test.add(34); test.add(45); test.add(73); test.add(8); return (test.isBinarySearchTree()); })(), 'The add method adds elements according to the binary search tree rules.');"
+          "testString": "assert((function() { var test = false; if (typeof BinarySearchTree !== 'undefined') { test = new BinarySearchTree() } else { return false; }; if (typeof test.add !== 'function') { return false; }; test.add(4); test.add(1); test.add(7); test.add(87); test.add(34); test.add(45); test.add(73); test.add(8); const expectedResult = [ 1, 4, 7, 8, 34, 45, 73, 87 ]; const result = test.inOrder(); return (expectedResult.toString() === result.toString()); })(), 'The add method adds elements according to the binary search tree rules.');"
         },
         {
           "text": "Adding an element that already exists returns <code>null</code>",
           "testString": "assert((function() { var test = false; if (typeof BinarySearchTree !== 'undefined') { test = new BinarySearchTree() } else { return false; }; if (typeof test.add !== 'function') { return false; }; test.add(4); return test.add(4) == null; })(), 'Adding an element that already exists returns <code>null</code>');"
         }
       ],
       "releasedOn": "Feb 17, 2017",
-      "solutions": [],
+      "solutions": ["function Node(value) { \n this.value = value; \n this.left = null; \n this.right = null; \n } \n function BinarySearchTree() { \n this.root = null; \n this.add = function (element) { \n let current = this.root; \n if (!current) { \n this.root = new Node(element) \n return; \n } else { \n const searchTree = function (current) { \n if (current.value > element) { \n if (current.left) { //si existe \n return searchTree(current.left) \n } else { \n current.left = new Node(element); \n return; \n } \n } else if (current.value < element) { \n  if (current.right) { \n return searchTree(current.right) \n } else { \n current.right = new Node(element) \n return; \n } \n } else { \n return null; \n } \n } \n return searchTree(current); \n } \n } \n }"],
       "challengeType": 1,
       "translations": {},
       "files": {
@@ -2228,6 +2228,19 @@
             "            return check;",
             "        };",
             "    }",
+            "};",
+            "BinarySearchTree.prototype = {",
+            "    inOrder() {",
+            "        if (!this.root) { return null; }",
+            "        var result = new Array();",
+            "        function traverseInOrder(node) {",
+            "             node.left && traverseInOrder(node.left);",
+            "             result.push(node.value);",
+            "             node.right && traverseInOrder(node.right);",
+            "        }",
+            "        traverseInOrder(this.root);",
+            "        return result;",
+            "    }",
             "};"
           ]
         }
@@ -3826,4 +3839,4 @@
       }
     }
   ]
-}
+}

Original file line number	Diff line number	Diff line change
`@@ -2169,15 +2169,15 @@`
`2169`	`2169`	`},`
`2170`	`2170`	`{`
`2171`	`2171`	`"text": "The add method adds elements according to the binary search tree rules.",`
`2172`		`- "testString": "assert((function() { var test = false; if (typeof BinarySearchTree !== 'undefined') { test = new BinarySearchTree() } else { return false; }; if (typeof test.add !== 'function') { return false; }; test.add(4); test.add(1); test.add(7); test.add(87); test.add(34); test.add(45); test.add(73); test.add(8); return (test.isBinarySearchTree()); })(), 'The add method adds elements according to the binary search tree rules.');"`
	`2172`	+ "testString": "assert((function() { var test = false; if (typeof BinarySearchTree !== 'undefined') { test = new BinarySearchTree() } else { return false; }; if (typeof test.add !== 'function') { return false; }; test.add(4); test.add(1); test.add(7); test.add(87); test.add(34); test.add(45); test.add(73); test.add(8); const expectedResult = [ 1, 4, 7, 8, 34, 45, 73, 87 ]; const result = test.inOrder(); return (expectedResult.toString() === result.toString()); })(), 'The add method adds elements according to the binary search tree rules.');"
`2173`	`2173`	`},`
`2174`	`2174`	`{`
`2175`	`2175`	`"text": "Adding an element that already exists returns <code>null</code>",`
`2176`	`2176`	`"testString": "assert((function() { var test = false; if (typeof BinarySearchTree !== 'undefined') { test = new BinarySearchTree() } else { return false; }; if (typeof test.add !== 'function') { return false; }; test.add(4); return test.add(4) == null; })(), 'Adding an element that already exists returns <code>null</code>');"`
`2177`	`2177`	`}`
`2178`	`2178`	`],`
`2179`	`2179`	`"releasedOn": "Feb 17, 2017",`
`2180`		`- "solutions": [],`
	`2180`	+ "solutions": ["function Node(value) { \n this.value = value; \n this.left = null; \n this.right = null; \n } \n function BinarySearchTree() { \n this.root = null; \n this.add = function (element) { \n let current = this.root; \n if (!current) { \n this.root = new Node(element) \n return; \n } else { \n const searchTree = function (current) { \n if (current.value > element) { \n if (current.left) { //si existe \n return searchTree(current.left) \n } else { \n current.left = new Node(element); \n return; \n } \n } else if (current.value < element) { \n if (current.right) { \n return searchTree(current.right) \n } else { \n current.right = new Node(element) \n return; \n } \n } else { \n return null; \n } \n } \n return searchTree(current); \n } \n } \n }"],
`2181`	`2181`	`"challengeType": 1,`
`2182`	`2182`	`"translations": {},`
`2183`	`2183`	`"files": {`
`@@ -2228,6 +2228,19 @@`
`2228`	`2228`	`" return check;",`
`2229`	`2229`	`" };",`
`2230`	`2230`	`" }",`
	`2231`	`+ "};",`
	`2232`	`+ "BinarySearchTree.prototype = {",`
	`2233`	`+ " inOrder() {",`
	`2234`	`+ " if (!this.root) { return null; }",`
	`2235`	`+ " var result = new Array();",`
	`2236`	`+ " function traverseInOrder(node) {",`
	`2237`	`+ " node.left && traverseInOrder(node.left);",`
	`2238`	`+ " result.push(node.value);",`
	`2239`	`+ " node.right && traverseInOrder(node.right);",`
	`2240`	`+ " }",`
	`2241`	`+ " traverseInOrder(this.root);",`
	`2242`	`+ " return result;",`
	`2243`	`+ " }",`
`2231`	`2244`	`"};"`
`2232`	`2245`	`]`
`2233`	`2246`	`}`
`@@ -3826,4 +3839,4 @@`
`3826`	`3839`	`}`
`3827`	`3840`	`}`
`3828`	`3841`	`]`
`3829`		`-}`
	`3842`	`+}`