Skip to content

Patch to fix query-node and integration tests build#1

Merged
freakstatic merged 1 commit intofreakstatic:nara-freeze-pallet-proposalfrom
mnaamani:patch-nara-freeze-pallet-proposal
Nov 2, 2023
Merged

Patch to fix query-node and integration tests build#1
freakstatic merged 1 commit intofreakstatic:nara-freeze-pallet-proposalfrom
mnaamani:patch-nara-freeze-pallet-proposal

Conversation

@mnaamani
Copy link
Copy Markdown

@mnaamani mnaamani commented Nov 2, 2023

Preliminary patch, not full implementation for query-node to support the new proposal.
This is intended just to get the builds to work.

'VetoProposal': 'vetoProposalProposalParameters',
'UpdateGlobalNftLimit': 'updateGlobalNftLimitProposalParameters',
'UpdateChannelPayouts': 'updateChannelPayoutsProposalParameters',
'FreezePallet': 'setInvitationCountProposalParameters',
Copy link
Copy Markdown
Author

@mnaamani mnaamani Nov 2, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

matching what was set in runtime, but I think setInvitationCountProposalParameters should be freezePalletProposalParameters or whatever name we end up choosing if the proposal name is changed.

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh yeah you are right it was a mistake on my end...
I will fix it in the freeze proposal PR

Copy link
Copy Markdown
Owner

@freakstatic freakstatic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
Thanks 🙏

@freakstatic freakstatic merged commit 4b46c64 into freakstatic:nara-freeze-pallet-proposal Nov 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants