Skip to content

fix: close Variable Manager on page navigation#524

Merged
surajshetty3416 merged 2 commits intofrappe:developfrom
aditorito:fix/variable-manager-page-switch
Mar 16, 2026
Merged

fix: close Variable Manager on page navigation#524
surajshetty3416 merged 2 commits intofrappe:developfrom
aditorito:fix/variable-manager-page-switch

Conversation

@aditorito
Copy link
Copy Markdown
Contributor

Fixes #523

The Variable Manager was staying open when switching between pages, floating over pages it had nothing to do with.

The fix watches for route changes and closes the Variable Manager whenever the user navigates to a different page. If they need it again, they can re-open it from the sidebar — same as any floating panel.

Changes made

  • Added a route watcher in LeftSidebarPanel that resets the Variable Manager visibility to closed on every page navigation

No breaking changes — only affects when the panel closes. All Variable Manager functionality (create, edit, delete, CSV import) is untouched.

Screen.Recording.2026-03-16.183413.mp4

@aditorito aditorito changed the title **fix: close Variable Manager on page navigation** fix: close Variable Manager on page navigation Mar 16, 2026
@codecov
Copy link
Copy Markdown

codecov bot commented Mar 16, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 63.07%. Comparing base (1e097bc) to head (1fcd02e).
⚠️ Report is 59 commits behind head on develop.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop     #524   +/-   ##
========================================
  Coverage    63.07%   63.07%           
========================================
  Files           27       27           
  Lines         2754     2754           
========================================
  Hits          1737     1737           
  Misses        1017     1017           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@surajshetty3416 surajshetty3416 merged commit 5b80f77 into frappe:develop Mar 16, 2026
6 checks passed
@github-actions
Copy link
Copy Markdown

🎉 This PR is included in version 1.23.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Variable Manager stays open when switching pages

2 participants